You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add version constraints to dependencies in the uses section
For better traceability and management of dependencies, consider adding explicit version constraints to the uses dependencies in the java_export target.
Why: Adding explicit version constraints to dependencies enhances traceability and management of dependencies, which is crucial for maintaining stable builds. This is a best practice that addresses a significant aspect of dependency management.
9
Specify the output directory for the bazel build command
Consider specifying the output directory for the bazel build command to ensure that the build artifacts are stored in a predictable and controlled location. This can help in managing the artifacts more effectively, especially in CI environments.
Why: Specifying the output directory for the bazel build command can help in managing build artifacts more effectively, especially in CI environments. This is a best practice that can improve the predictability and control of build outputs.
8
Maintainability
Add a description to the pkg_zip target
It's recommended to add a description for the pkg_zip target to clarify its purpose and usage within the project. This can improve maintainability and understanding of the build configuration.
pkg_zip(
name = "strongnamed",
srcs = [
"//dotnet/src/support:support-strongnamed-pack",
"//dotnet/src/webdriver:webdriver-strongnamed-pack",
],
tags = [
"release-artifact",
],
+ description = "Package for strongly named assemblies of the project."
)
Apply this suggestion
Suggestion importance[1-10]: 7
Why: Adding a description to the pkg_zip target can improve maintainability and understanding of the build configuration. This is a minor but useful improvement for documentation purposes.
7
Standardize the formatting of the tags list
Ensure consistent formatting of the tags list across all java_export targets to improve readability and maintainability of the build scripts.
Why: Standardizing the formatting of the tags list improves readability and maintainability of the build scripts. This is a minor improvement focused on code style.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
This means the
ci-build.shscript can be shrunk by removing the hard-coded list of artifacts.PR Type
Enhancement, Configuration changes
Description
ci-build.shscript.release-artifacttag to various Bazel build targets across multiple languages (.NET, Java, JavaScript, Python, Ruby).release-artifacttag.Changes walkthrough 📝
1 files
ci-build.sh
Dynamically select artifacts to build using tag filtersscripts/github-actions/ci-build.sh
--build_tag_filters=release-artifactto dynamically selectartifacts.
24 files
BUILD.bazel
Add release-artifact tag to .NET build targetsdotnet/BUILD.bazel
release-artifacttag tostrongnamedandreleasetargets.BUILD.bazel
Add release-artifact tag to Selenium Java API targetsjava/src/org/openqa/selenium/BUILD.bazel
release-artifacttag toselenium-apiandclient-combinedtargets.
BUILD.bazel
Add release-artifact tag to Selenium Chrome driver targetjava/src/org/openqa/selenium/chrome/BUILD.bazel
release-artifacttag tochrometarget.BUILD.bazel
Add release-artifact tag to Selenium Chromium driver targetjava/src/org/openqa/selenium/chromium/BUILD.bazel
release-artifacttag tochromiumtarget.BUILD.bazel
Add release-artifact tag to Selenium DevTools v125 targetjava/src/org/openqa/selenium/devtools/v125/BUILD.bazel
release-artifacttag toselenium-devtools-v125target.BUILD.bazel
Add release-artifact tag to Selenium DevTools v126 targetjava/src/org/openqa/selenium/devtools/v126/BUILD.bazel
release-artifacttag toselenium-devtools-v126target.BUILD.bazel
Add release-artifact tag to Selenium DevTools v127 targetjava/src/org/openqa/selenium/devtools/v127/BUILD.bazel
release-artifacttag toselenium-devtools-v127target.BUILD.bazel
Add release-artifact tag to Selenium DevTools v85 targetjava/src/org/openqa/selenium/devtools/v85/BUILD.bazel
release-artifacttag toselenium-devtools-v85target.BUILD.bazel
Add release-artifact tag to Selenium Edge driver targetjava/src/org/openqa/selenium/edge/BUILD.bazel
release-artifacttag toedgetarget.BUILD.bazel
Add release-artifact tag to Selenium Firefox driver targetjava/src/org/openqa/selenium/firefox/BUILD.bazel
release-artifacttag tofirefoxtarget.BUILD.bazel
Add release-artifact tag to Selenium Grid and BOM targetsjava/src/org/openqa/selenium/grid/BUILD.bazel
release-artifacttag toselenium-bomandgridtargets.BUILD.bazel
Add release-artifact tag to Selenium JDBC session map targetjava/src/org/openqa/selenium/grid/sessionmap/jdbc/BUILD.bazel
release-artifacttag tojdbctarget.BUILD.bazel
Add release-artifact tag to Selenium Redis session map targetjava/src/org/openqa/selenium/grid/sessionmap/redis/BUILD.bazel
release-artifacttag toredistarget.BUILD.bazel
Add release-artifact tag to Selenium IE driver targetjava/src/org/openqa/selenium/ie/BUILD.bazel
release-artifacttag toietarget.BUILD.bazel
Add release-artifact tag to Selenium JSON targetjava/src/org/openqa/selenium/json/BUILD.bazel
release-artifacttag tojsontarget.BUILD.bazel
Add release-artifact tag to Selenium Manager targetjava/src/org/openqa/selenium/manager/BUILD.bazel
release-artifacttag tomanagertarget.BUILD.bazel
Add release-artifact tag to Selenium OS targetjava/src/org/openqa/selenium/os/BUILD.bazel
release-artifacttag toostarget.BUILD.bazel
Add release-artifact tag to Selenium Remote Driver targetjava/src/org/openqa/selenium/remote/BUILD.bazel
release-artifacttag toremote-drivertarget.BUILD.bazel
Add release-artifact tag to Selenium HTTP targetjava/src/org/openqa/selenium/remote/http/BUILD.bazel
release-artifacttag tohttptarget.BUILD.bazel
Add release-artifact tag to Selenium Safari driver targetjava/src/org/openqa/selenium/safari/BUILD.bazel
release-artifacttag tosafaritarget.BUILD.bazel
Add release-artifact tag to Selenium Support targetjava/src/org/openqa/selenium/support/BUILD.bazel
release-artifacttag tosupporttarget.BUILD.bazel
Add release-artifact tag to Selenium WebDriver JavaScript targetjavascript/node/selenium-webdriver/BUILD.bazel
release-artifacttag toselenium-webdrivertarget.BUILD.bazel
Add release-artifact tag to Selenium Python Wheel targetpy/BUILD.bazel
release-artifacttag toselenium-wheeltarget.BUILD.bazel
Add release-artifact tag to Selenium Ruby targetsrb/BUILD.bazel
release-artifacttag toselenium-webdriverandselenium-devtoolstargets.