Skip to content

[dotnet][rb][java][js][py] Automated Browser Version Update #13517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/bazel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ on:
required: false
type: string
default: ''
artifact-name:
description: Name of artifact to upload
required: false
type: string
default: 'ignore-artifacts'

jobs:
bazel:
Expand Down Expand Up @@ -141,11 +146,13 @@ jobs:
prerelease: true
files: ${{ inputs.nightly-release-files }}
- name: Save changes
if: ${{ always() && inputs.artifact-name != 'ignore-artifacts' }}
run: |
git diff > changes.patch
- name: "Upload changes"
uses: actions/upload-artifact@v3
if: ${{ always() && inputs.artifact-name != 'ignore-artifacts' }}
uses: actions/upload-artifact@v4
with:
name: patch-file
name: ${{ inputs.artifact-name }}
path: changes.patch
retention-days: 6
14 changes: 7 additions & 7 deletions .github/workflows/ci-rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
- name: "Rename binary"
run: mv rust/target/release/selenium-manager.exe selenium-manager-windows.exe
- name: "Upload release binary"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: selenium-manager-windows
path: selenium-manager-windows.exe
Expand Down Expand Up @@ -83,7 +83,7 @@ jobs:
- name: "Rename binary"
run: mv rust/target/debug/selenium-manager.exe selenium-manager-windows-debug.exe
- name: "Upload release binary"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: selenium-manager-windows-debug
path: selenium-manager-windows-debug.exe
Expand Down Expand Up @@ -111,7 +111,7 @@ jobs:
- name: "Rename binary"
run: mv rust/target/x86_64-unknown-linux-musl/release/selenium-manager selenium-manager-linux
- name: "Upload release binary"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: selenium-manager-linux
path: selenium-manager-linux
Expand Down Expand Up @@ -140,7 +140,7 @@ jobs:
tar -cvf ../../../../selenium-manager-linux-debug.tar selenium-manager
working-directory: rust
- name: "Upload release binary"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: selenium-manager-linux-debug
path: selenium-manager-linux-debug.tar
Expand Down Expand Up @@ -170,7 +170,7 @@ jobs:
target/x86_64-apple-darwin/release/selenium-manager
working-directory: rust
- name: "Upload release binary"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: selenium-manager-macos
path: rust/target/selenium-manager-macos
Expand Down Expand Up @@ -202,7 +202,7 @@ jobs:
tar -cvf ../../selenium-manager-macos-debug.tar selenium-manager
working-directory: rust
- name: "Upload release binary"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: selenium-manager-macos-debug
path: selenium-manager-macos-debug.tar
Expand All @@ -220,7 +220,7 @@ jobs:
token: ${{ secrets.SELENIUM_CI_TOKEN }}
repository: SeleniumHQ/selenium_manager_artifacts
- name: "Download Artifacts"
uses: actions/download-artifact@v2
uses: actions/download-artifact@v4
with:
path: artifacts
- name: "Prepare and Commit"
Expand Down
12 changes: 8 additions & 4 deletions .github/workflows/pin-browsers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ jobs:
name: Pin Browsers
cache-key: pin-browsers
run: bazel run //scripts:pinned_browsers
artifact-name: pinned-browsers

pull-request:
if: github.repository_owner == 'seleniumhq'
Expand All @@ -23,7 +24,7 @@ jobs:
- name: Download patch
uses: actions/download-artifact@v4
with:
name: patch-file
name: pinned-browsers
- name: Apply Patch
run: |
git apply changes.patch
Expand All @@ -39,9 +40,12 @@ jobs:
with:
token: ${{ secrets.SELENIUM_CI_TOKEN }}
add-paths: common/repositories.bzl
commit-message: Update pinned browser versions
commit-message: "Update pinned browser versions"
committer: Selenium CI Bot <selenium-ci@users.noreply.github.com>
author: Selenium CI Bot <selenium-ci@users.noreply.github.com>
title: "Automated Browser Version Update"
body: "This is an automated pull request to update pinned browsers and drivers"
title: "[dotnet][rb][java][js][py] Automated Browser Version Update"
body: |
This is an automated pull request to update pinned browsers and drivers

Merge after verify the new browser versions properly passing the tests and no bugs need to be filed
branch: "pinned-browser-updates"
30 changes: 15 additions & 15 deletions common/repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ def pin_browsers():

http_archive(
name = "linux_firefox",
url = "https://ftp.mozilla.org/pub/firefox/releases/121.0.1/linux-x86_64/en-US/firefox-121.0.1.tar.bz2",
sha256 = "0fb696e03ac444d6c973cf3ff9f9c123b369e2091c80b50753ff1b447f1a96c1",
url = "https://ftp.mozilla.org/pub/firefox/releases/122.0/linux-x86_64/en-US/firefox-122.0.tar.bz2",
sha256 = "0b36d796ba88d48000b0a3e43854a00556148221776879c91fae03735a0e5c21",
build_file_content = """
filegroup(
name = "files",
Expand All @@ -27,15 +27,15 @@ exports_files(

dmg_archive(
name = "mac_firefox",
url = "https://ftp.mozilla.org/pub/firefox/releases/121.0.1/mac/en-US/Firefox%20121.0.1.dmg",
sha256 = "234b599abbbcf2ba553a625e2e97437cef08008a4d8484d9b889d8954372acf2",
url = "https://ftp.mozilla.org/pub/firefox/releases/122.0/mac/en-US/Firefox%20122.0.dmg",
sha256 = "ccd68fe5388b044062410ce71885911f618fd4222cd617e429eb8ab0b68795d4",
build_file_content = "exports_files([\"Firefox.app\"])",
)

http_archive(
name = "linux_beta_firefox",
url = "https://ftp.mozilla.org/pub/firefox/releases/122.0b9/linux-x86_64/en-US/firefox-122.0b9.tar.bz2",
sha256 = "f556ac661b870f791eac7ed5a3cd1299f4cd370cbfd671dd3d26277502470b16",
url = "https://ftp.mozilla.org/pub/firefox/releases/123.0b3/linux-x86_64/en-US/firefox-123.0b3.tar.bz2",
sha256 = "496be0e58074ce544a00fce8e67c36db685590f5ecc0319c8388fdda0b9f0dd0",
build_file_content = """
filegroup(
name = "files",
Expand All @@ -51,15 +51,15 @@ exports_files(

dmg_archive(
name = "mac_beta_firefox",
url = "https://ftp.mozilla.org/pub/firefox/releases/122.0b9/mac/en-US/Firefox%20122.0b9.dmg",
sha256 = "ad9eb86051a84445f8d519cc38ebbf06a55a2ed60d371ddc143c6bf42a548f8e",
url = "https://ftp.mozilla.org/pub/firefox/releases/123.0b3/mac/en-US/Firefox%20123.0b3.dmg",
sha256 = "ba06728492cbe18f1194cf7cd5e9ee3ad271cda5ae9e2f845851691911b72a84",
build_file_content = "exports_files([\"Firefox.app\"])",
)

http_archive(
name = "linux_dev_firefox",
url = "https://ftp.mozilla.org/pub/firefox/releases/122.0b9/linux-x86_64/en-US/firefox-122.0b9.tar.bz2",
sha256 = "f556ac661b870f791eac7ed5a3cd1299f4cd370cbfd671dd3d26277502470b16",
url = "https://ftp.mozilla.org/pub/firefox/releases/123.0b3/linux-x86_64/en-US/firefox-123.0b3.tar.bz2",
sha256 = "496be0e58074ce544a00fce8e67c36db685590f5ecc0319c8388fdda0b9f0dd0",
build_file_content = """
filegroup(
name = "files",
Expand All @@ -75,8 +75,8 @@ exports_files(

dmg_archive(
name = "mac_dev_firefox",
url = "https://ftp.mozilla.org/pub/firefox/releases/122.0b9/mac/en-US/Firefox%20122.0b9.dmg",
sha256 = "ad9eb86051a84445f8d519cc38ebbf06a55a2ed60d371ddc143c6bf42a548f8e",
url = "https://ftp.mozilla.org/pub/firefox/releases/123.0b3/mac/en-US/Firefox%20123.0b3.dmg",
sha256 = "ba06728492cbe18f1194cf7cd5e9ee3ad271cda5ae9e2f845851691911b72a84",
build_file_content = "exports_files([\"Firefox.app\"])",
)

Expand All @@ -96,10 +96,10 @@ exports_files(

pkg_archive(
name = "mac_edge",
url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/8e50e03c-aa9a-467d-bbb4-3b93045ed5b9/MicrosoftEdge-120.0.2210.144.pkg",
sha256 = "5f5190720d612224222dfba6746d9893d73f70abe57d14866552b3944b0d01f3",
url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/7a610a85-f171-4858-ab93-06908d04c1d6/MicrosoftEdge-121.0.2277.83.pkg",
sha256 = "3b2b3b919558147dccf993a0d86f7eb04782b8d7f39aeb9c719b2dc381f262ba",
move = {
"MicrosoftEdge-120.0.2210.144.pkg/Payload/Microsoft Edge.app": "Edge.app",
"MicrosoftEdge-121.0.2277.83.pkg/Payload/Microsoft Edge.app": "Edge.app",
},
build_file_content = "exports_files([\"Edge.app\"])",
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import static org.junit.jupiter.api.Assumptions.assumeFalse;
import static org.openqa.selenium.testing.TestUtilities.getEffectivePlatform;
import static org.openqa.selenium.testing.drivers.Browser.EDGE;
import static org.openqa.selenium.testing.drivers.Browser.FIREFOX;
import static org.openqa.selenium.testing.drivers.Browser.IE;
import static org.openqa.selenium.testing.drivers.Browser.SAFARI;

Expand Down Expand Up @@ -222,9 +221,6 @@ void canGenerateKeyboardShortcuts() {
@NotYetImplemented(SAFARI)
@NotYetImplemented(IE)
@NotYetImplemented(EDGE)
@NotYetImplemented(
value = FIREFOX,
reason = "https://bugzilla.mozilla.org/show_bug.cgi?id=1422583")
public void testSelectionSelectBySymbol() {
driver.get(appServer.whereIs("single_text_input.html"));

Expand Down Expand Up @@ -254,9 +250,6 @@ public void testSelectionSelectBySymbol() {
@NotYetImplemented(IE)
@NotYetImplemented(EDGE)
@Ignore(IE)
@NotYetImplemented(
value = FIREFOX,
reason = "https://bugzilla.mozilla.org/show_bug.cgi?id=1422583")
public void testSelectionSelectByWord() {
assumeFalse(getEffectivePlatform(driver).is(Platform.MAC), "MacOS has alternative keyboard");

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
import static org.openqa.selenium.testing.Safely.safelyCall;
import static org.openqa.selenium.testing.drivers.Browser.EDGE;
import static org.openqa.selenium.testing.drivers.Browser.FIREFOX;
import static org.openqa.selenium.testing.drivers.Browser.IE;
import static org.openqa.selenium.testing.drivers.Browser.SAFARI;

Expand Down Expand Up @@ -148,7 +147,6 @@ void canListenToResponseCompletedEventWithCookie()
@NotYetImplemented(SAFARI)
@NotYetImplemented(IE)
@NotYetImplemented(EDGE)
@NotYetImplemented(FIREFOX) // Implemented in Firefox Nightly version 123
void canListenToOnAuthRequiredEvent()
throws ExecutionException, InterruptedException, TimeoutException {
try (Network network = new Network(driver)) {
Expand Down