Skip to content

Enhancements to the PhantomJSDriverService to support passing command-line arguments to PhantomJS.exe #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gmcelhanon wants to merge 1 commit into from
Closed

Enhancements to the PhantomJSDriverService to support passing command-line arguments to PhantomJS.exe #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 24 additions & 20 deletions dotnet/src/WebDriver/PhantomJS/PhantomJSDriver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,12 @@
// </copyright>

using System;
using System.Collections.Generic;
using System.Globalization;
using System.Net;
using System.Net.Sockets;
using System.Text;
using OpenQA.Selenium.Internal;
using OpenQA.Selenium.Remote;

namespace OpenQA.Selenium.PhantomJS
{
/// <summary>
/// Provides a way to access PhantomJS to run your tests by creating a PhantomJSDriver instance
/// Provides a way to access PhantomJS to run your tests by creating a PhantomJSDriver instance.
/// </summary>
/// <remarks>
/// When the WebDriver object has been instantiated the browser will load. The test can then navigate to the URL under test and
Expand Down Expand Up @@ -71,12 +65,12 @@ public class PhantomJSDriver : RemoteWebDriver, ITakesScreenshot
/// Initializes a new instance of the <see cref="PhantomJSDriver"/> class.
/// </summary>
public PhantomJSDriver()
: this(new PhantomJSOptions())
: this(PhantomJSDriverService.CreateDefaultService())
{
}

/// <summary>
/// Initializes a new instance of the <see cref="PhantomJSDriver"/> class with the desired options.
/// Initializes a new instance of the PhantomJSDriver class with the desired options.
/// </summary>
/// <param name="options">The <see cref="PhantomJSOptions"/> used to initialize the driver.</param>
public PhantomJSDriver(PhantomJSOptions options)
Expand All @@ -85,28 +79,28 @@ public PhantomJSDriver(PhantomJSOptions options)
}

/// <summary>
/// Initializes a new instance of the <see cref="PhantomJSDriver"/> class using the specified path
/// Initializes a new instance of the PhantomJSDriver class using the specified path
/// to the directory containing PhantomJS.exe.
/// </summary>
/// <param name="phantomJSDriverServerDirectory">The full path to the directory containing PhantomJS.exe.</param>
public PhantomJSDriver(string phantomJSDriverServerDirectory)
: this(phantomJSDriverServerDirectory, new PhantomJSOptions())
: this(PhantomJSDriverService.CreateDefaultService(phantomJSDriverServerDirectory), new PhantomJSOptions())
{
}

/// <summary>
/// Initializes a new instance of the <see cref="PhantomJSDriver"/> class using the specified path
/// Initializes a new instance of the PhantomJSDriver class using the specified path
/// to the directory containing PhantomJS.exe and options.
/// </summary>
/// <param name="phantomJSDriverServerDirectory">The full path to the directory containing PhantomJS.exe.</param>
/// <param name="options">The <see cref="PhantomJSOptions"/> used to initialize the driver.</param>
public PhantomJSDriver(string phantomJSDriverServerDirectory, PhantomJSOptions options)
: this(phantomJSDriverServerDirectory, options, RemoteWebDriver.DefaultCommandTimeout)
: this(PhantomJSDriverService.CreateDefaultService(phantomJSDriverServerDirectory), options, TimeSpan.FromSeconds(60))
{
}

/// <summary>
/// Initializes a new instance of the <see cref="PhantomJSDriver"/> class using the specified path
/// Initializes a new instance of the PhantomJSDriver class using the specified path
/// to the directory containing PhantomJS.exe, options, and command timeout.
/// </summary>
/// <param name="phantomJSDriverServerDirectory">The full path to the directory containing PhantomJS.exe.</param>
Expand All @@ -118,20 +112,30 @@ public PhantomJSDriver(string phantomJSDriverServerDirectory, PhantomJSOptions o
}

/// <summary>
/// Initializes a new instance of the <see cref="PhantomJSDriver"/> class using the specified
/// <see cref="PhantomJSDriverService"/> and options.
/// Initializes a new instance of the <see cref="PhantomJSDriver"/> class with the specified
/// <see cref="PhantomJSDriverService"/> instance.
/// </summary>
/// <param name="service">The <see cref="PhantomJSDriverService"/> to use.</param>
/// <param name="service">The <see cref="PhantomJSDriverService"/> instance to use.</param>
public PhantomJSDriver(PhantomJSDriverService service)
: this(service, new PhantomJSOptions())
{
}

/// <summary>
/// Initializes a new instance of the <see cref="PhantomJSDriver"/> class with the specified
/// <see cref="PhantomJSDriverService"/> instance and desired options.
/// </summary>
/// <param name="service">The <see cref="PhantomJSDriverService"/> instance to use.</param>
/// <param name="options">The <see cref="PhantomJSOptions"/> used to initialize the driver.</param>
public PhantomJSDriver(PhantomJSDriverService service, PhantomJSOptions options)
: this(service, options, RemoteWebDriver.DefaultCommandTimeout)
: this(service, options, TimeSpan.FromSeconds(60))
{
}

/// <summary>
/// Initializes a new instance of the PhantomJSDriver class using the specified <see cref="PhantomJSDriverService"/>.
/// Initializes a new instance of the <see cref="PhantomJSDriver"/> class using the specified <see cref="DriverService"/>.
/// </summary>
/// <param name="service">The <see cref="PhantomJSDriverService"/> to use.</param>
/// <param name="service">The <see cref="PhantomJSDriverService"/> instance to use.</param>
/// <param name="options">The <see cref="PhantomJSOptions"/> used to initialize the driver.</param>
/// <param name="commandTimeout">The maximum amount of time to wait for each command.</param>
public PhantomJSDriver(PhantomJSDriverService service, PhantomJSOptions options, TimeSpan commandTimeout)
Expand Down
Loading