-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decorator should honour implementation checks #11438
Conversation
SonarCloud Quality Gate failed. |
java/test/org/openqa/selenium/support/events/EventFiringDecoratorTest.java
Outdated
Show resolved
Hide resolved
Codecov ReportBase: 54.54% // Head: 54.54% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## trunk #11438 +/- ##
=======================================
Coverage 54.54% 54.54%
=======================================
Files 85 85
Lines 5627 5627
Branches 243 243
=======================================
Hits 3069 3069
Misses 2315 2315
Partials 243 243 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I debugged through the fix and it is solving the issue accurately. Overall, PR looks good to me. Once the comments are addressed and all checks pass, I will merge the PR. Thank you! |
8dd4e3e
to
bf425aa
Compare
I have addressed the review comment and responded to the other one. Also rebased off of trunk and force pushed the amended commit. Please help take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @krmahadevan!
Fixes SeleniumHQ#11432 The current web driver decorator looks for Class name compatibility against a bunch of interfaces. So this works with we use WebDriver but does not Work when we use RemoteWebDriver. Altered the logic to use assignability checks between classes instead of doing a equals check.
bf425aa
to
7e5cdb4
Compare
Fixes #11432
The current web driver decorator looks for
Class name compatibility against a bunch of interfaces.
So this works with we use WebDriver but does not
Work when we use RemoteWebDriver.
Altered the logic to use assignability checks between classes instead of doing a equals check.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
The current web driver decorator looks for
Class name compatibility against a bunch of interfaces.
So this works with we use WebDriver but does not
Work when we use RemoteWebDriver.
Altered the logic to use assignability checks between classes instead of doing a equals check.
Description
Motivation and Context
Types of changes
Checklist