Selenium doesn't display the stacktrace from geckodriver exceptions, because the key is cased differently

[jwg4]

Meta -

OS: Linux (Ubuntu 14.04)
Selenium Version:
3.3.1
Browser:
Firefox / geckodriver 0.15.0

Expected Behavior -

If geckodriver throws an exception with a stacktrace, selenium should display that stacktrace in the message for the WebDriverException it generates.

Actual Behavior -

The message is empty, even if a stacktrace is present.

It seems the selenium code looks for the key 'stackTrace' in an exception JSON passed from a webdriver. See https://github.com/SeleniumHQ/selenium/blob/master/py/selenium/webdriver/remote/errorhandler.py#L173 However geckodriver uses 'stacktrace', all lower case, as per the W3 spec: https://www.w3.org/TR/webdriver/

I haven't checked every single one, but other languages appear to do the same thing. Would a PR checking for both keys be accepted? If so, is it legit to just patch one language's code, or does this cause more problems than it solves? Thanks.

[isaulv]

@AutomatedTester this needs attention.

[jwg4]

Any feedback on this issue?

[lmtierney]

Looks like a legitimate issue that we need to address in all languages, would like confirmation from one of the spec leads @AutomatedTester or @shs96c

[AutomatedTester]

We're going to have to update the spec to do stackTrace. We are also going to have to update the bindings for a short term to handle both stacktrace and stackTrace

[barancev]

Java handles both protocol versions.