-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
K8s: Fix deployment config error in video-manager #2831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
CI Feedback 🧐(Feedback updated until commit 60d221b)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
12c52f6 to
60d221b
Compare
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
60d221b to
f928f6f
Compare
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
We utilize File Browser as a video manager. It is a web-based file manager that allows you to manage files and folders in the storage. The video manager is disabled by default. To enable it, you need to set config key
videoManager.enabledtotrue.The service can be exposed via NodePort or Ingress (if enabled global ingress). By default, there is a baseurl is
/recordings, if enabled svc type NodePort:http://<node-ip>:30080/recordings, or ingresshttp://<ingress-hostname>/recordings. You also can change the baseurl to another value via config keyvideoManager.config.baseurlThe File Browser container dir
/srvshould be mounted to the same storage as video recordings stored. The storage here is persistent volume claim (PVC) that is created by you or dynamically provisioned by the storage class. Configure recorder and manager to use the same PVC. For exampleWhen configuration is done, via File Browser you can centralize all the recordings in one place. You can manage the recordings, delete them, or download them.
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement, Documentation
Description
Add documentation for video recordings manager using File Browser
Update Helm chart and values for video manager base URL
baseurlto/recordingsfor consistencyProvide reference Kubernetes and Helm chart values for local testing
Minor Helm template fixes for KEDA and node naming consistency
Changes walkthrough 📝
4 files
Add section on video recordings manager with File BrowserDocument video manager setup and usage in Helm chartUpdate video manager baseurl default and documentationAdd guide for local Kubernetes setup and Helm testing4 files
Change videoManager.config.baseurl default to `/recordings`Use updated baseurl for ingress pathAdd PVC manifest for local Docker Desktop testingAdd sample Helm values for local Selenium Grid deployment2 files
Fix KEDA usage condition in chrome node scaled jobsFix KEDA usage condition in relay node scaled jobs1 files
Add CHANGELOG.md and TESTING.md to Helm ignore list