-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Docker: Remove Hub GraphQL dependency from video recorder #2813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Feedback 🧐(Feedback updated until commit 10c1a3a)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
3b5e9df
to
10c1a3a
Compare
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
After the fix [java] Add "se" prefixed capabilities to session response (SeleniumHQ/selenium#14323) available from version 4.24+
All capabilities with prefix
se:
could be seen in Node/status
session capabilities.Video recorder to get file name via cap
se:name
, orse:videoName
no need to extract from Hub GraphQL anymore.Container video recorder also no need to pass ENV variable of Hub GraphQL anymore.
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Remove Hub GraphQL dependency from video recorder logic
/status
endpointAdd new script to extract video recording info from capabilities
Changes walkthrough 📝
video.sh
Refactor video recorder to use Node session capabilities
Video/video.sh
/status
endpoint, notGraphQL
extraction
video_nodeQuery.sh
Add script to parse video recording info from capabilities
Video/video_nodeQuery.sh
capabilities
se:name
orse:videoName
capabilities