-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Docker: Use curl static binary #2725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Feedback 🧐(Feedback updated until commit 8890897)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
05eea60
to
6bdd879
Compare
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
9abb07f
to
a690dee
Compare
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes #2719
Current,
curl
is installed viaapt-get
only stay with the versionv8.5
, meanwhile latest upstream isv8.12.1
.Looks like deb repo, they lost the maintenance to bump new version.
Switch to use static
curl
binary is built from this project https://github.com/moparisthebest/static-curl/releases/ until deb repo could update new versionMotivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Added support for using a static curl binary.
Updated dependencies in
.ffmpeg/Dockerfile
to fix CVEs.Modified
Base/Dockerfile
to include new Ubuntu sources.Replaced
curl
package with a static binary for better compatibility.Changes walkthrough 📝
Dockerfile
Updated dependencies and added GO_NET_VERSION argument
.ffmpeg/Dockerfile
GO_NET_VERSION
argument for dependency management.go.mod
to includegolang.org/x/net
version.Dockerfile
Added Ubuntu sources and static curl binary
Base/Dockerfile
noble
distribution.curl
package with a static binary.