Skip to content

Conversation

@VietND96
Copy link
Member

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

  1. PR Update Dockerfile - external jar version uplift #2015 upgraded io.opentelemetry from 1.31.0 to 1.32.0
    It caused issue that when SE_ENABLE_TRACING: true, Hub (Router) could not start due to [🐛 Bug]: Router can't start #2038
Caused by: java.lang.NoSuchMethodError: 'void io.opentelemetry.sdk.internal.DaemonThreadFactory.<init>(java.lang.String, boolean)'
    at io.opentelemetry.exporter.sender.okhttp.internal.OkHttpUtil.newDispatcher(OkHttpUtil.java:31)
  1. Added sanity test for tracing enabled to guarantee regression issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…cing enabled

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@VietND96 VietND96 linked an issue Nov 30, 2023 that may be closed by this pull request
@VietND96 VietND96 merged commit 8fd00ef into SeleniumHQ:trunk Dec 1, 2023
@VietND96 VietND96 deleted the helm-chart branch December 2, 2023 12:24
@VietND96 VietND96 self-assigned this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Router can't start

1 participant