Skip to content

Commit

Permalink
chart: Deployment scale metricType should be Value instead of Average…
Browse files Browse the repository at this point in the history
…Value

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
  • Loading branch information
VietND96 committed Nov 13, 2024
1 parent bf73ae9 commit e976dd7
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion NodeChromium/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ USER root
# Install Chromium
ARG CHROMIUM_VERSION="latest"
ARG CHROMIUM_DEB_SITE="http://deb.debian.org/debian"
RUN echo "deb ${CHROMIUM_DEB_SITE}/ sid main" >> /etc/apt/sources.list \
RUN echo "deb ${CHROMIUM_DEB_SITE}/ stable main" >> /etc/apt/sources.list \
&& wget -qO- https://ftp-master.debian.org/keys/archive-key-12.asc | gpg --dearmor > /etc/apt/trusted.gpg.d/debian-archive-keyring.gpg \
&& wget -qO- https://ftp-master.debian.org/keys/archive-key-12-security.asc | gpg --dearmor > /etc/apt/trusted.gpg.d/debian-archive-security-keyring.gpg \
&& apt-get update -qqy \
Expand Down
1 change: 1 addition & 0 deletions charts/selenium-grid/CONFIGURATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,7 @@ A Helm chart for creating a Selenium Grid Server in Kubernetes
| autoscaling.scaledJobOptions.failedJobsHistoryLimit | int | `0` | Number of Failed jobs should be kept (for troubleshooting purposes) |
| autoscaling.scaledJobOptions.jobTargetRef | object | `{"backoffLimit":0,"completions":1,"parallelism":1}` | Specify job target ref for KEDA ScaledJob |
| autoscaling.scaledObjectOptions.scaleTargetRef.kind | string | `"Deployment"` | Target reference for KEDA ScaledObject |
| autoscaling.scaledObjectOptions.advanced.scalingModifiers.metricType | string | `"Value"` | |
| autoscaling.terminationGracePeriodSeconds | int | `3600` | Define terminationGracePeriodSeconds for scalingType "deployment". Period for `deregisterLifecycle` to gracefully shut down the node before force terminating it |
| autoscaling.deregisterLifecycle | string | `nil` | Define preStop command to shut down the node gracefully when scalingType is set to "deployment" |
| chromeNode.enabled | bool | `true` | Enable chrome nodes |
Expand Down
1 change: 1 addition & 0 deletions charts/selenium-grid/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ Common autoscaling spec template
{{- if not $.Values.autoscaling.scaledOptions.triggers }}
triggers:
- type: selenium-grid
name: selenium-grid
metadata:
nodeMaxSessions: {{ $nodeMaxSessions | quote }}
{{- with .node.hpa }}
Expand Down
4 changes: 4 additions & 0 deletions charts/selenium-grid/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -894,6 +894,10 @@ autoscaling:
scaleTargetRef:
# -- Target reference for KEDA ScaledObject
kind: Deployment
advanced:
scalingModifiers:
metricType: "Value"
formula: "selenium-grid"
# -- Define terminationGracePeriodSeconds for scalingType "deployment". Period for `deregisterLifecycle` to gracefully shut down the node before force terminating it
terminationGracePeriodSeconds: 3600
# -- Define preStop command to shut down the node gracefully when scalingType is set to "deployment"
Expand Down

0 comments on commit e976dd7

Please sign in to comment.