upgrade master to elixir1.14 #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 7, 2024 08:55
Merged
bmfay
reviewed
Nov 7, 2024
Comment on lines
+28
to
+29
| @ja_resource_repo Application.compile_env(:ja_resource, :repo) | ||
| if @ja_resource_repo do |
Collaborator
There was a problem hiding this comment.
If i think harder I could figure it out but easier to ask: why compile vs get?
Collaborator
Author
There was a problem hiding this comment.
that's the issue with elixir 1.14. it doesn't want you to use fetch_env/get_env when you are outside of a function body because the value should be defined before compile time.
bmfay
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.