fix(pipeline-gw): shutdown - wait for envoy to remove route #6802
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lc525
approved these changes
Sep 24, 2025
| ) | ||
|
|
||
| const ( | ||
| waitForRouteToBeRemovedFromEnvoy = 1 * time.Second |
There was a problem hiding this comment.
This might not be enough with multiple envoy replicas, but it's a good point to start from. Did you by any chance run with multiple envoy replicas already?
There was a problem hiding this comment.
Let me test that scenario, only tested with 1
domsolutions
force-pushed
the
fix/pipeline-gw-shutdown-envoy
branch
from
836fc03 to
7accca8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Under load when
pipeline-gwshutsdown, on occasion we'd get 503s as envoy would still proxy reqs while HTTP/gRPC were gracefully shutting down and no longer accepting new connections.Summary of changes
1 secondafter closing connection to scheduler which will trigger envoy cluster updateChecklist
Testing