-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.10 #605
Add Python 3.10 #605
Conversation
This is currently blocked by pytorch/pytorch#66424. |
I guess technically |
According to the PyTorch changelog (https://github.com/pytorch/pytorch/releases) the latest pytorch version (1.11) now supports Python 3.10 (although pytorch/pytorch#66424 suggests they won't have CI for it until 1.12). Given that |
Looks like the latest build failure is down to the We might also just be able to enforce a newer p.s. Could also just pin the Windows/MacOS CI to 3.9 for now... |
Codecov Report
@@ Coverage Diff @@
## master #605 +/- ##
==========================================
- Coverage 82.10% 80.39% -1.71%
==========================================
Files 77 77
Lines 10570 10597 +27
==========================================
- Hits 8678 8519 -159
- Misses 1892 2078 +186
|
The typo
|
README.md
Outdated
@@ -5,7 +5,7 @@ | |||
<!--- BADGES: START ---> | |||
|
|||
<!--- | |||
![Python version](https://img.shields.io/badge/python-3.7%20%7C%203.8%20%7C%203.9-blue.svg) | |||
![Python version](https://img.shields.io/badge/python-3.7%20%7C%203.8%20%7C%203.9%20%7C%203.10-blue.svg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need a rebase which should throw up another merge conflict as this has been automated on master
. Not sure why it hasn't been thrown up already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because I screwed up. The above two lines are fenced inside comments, so the above change did nothing.
I actually updated the correct line (line 14) to use the automated versioning yesterday (5efc04b), so there is no need to update this manually at all now...
Will delete the confusing commented lines in master
and rebase.
Addresses #601