Fix fetch_tf_model download path handling for newer Keras versions - #955
Open
rashidrao-pk wants to merge 1 commit into
Open
Fix fetch_tf_model download path handling for newer Keras versions#955rashidrao-pk wants to merge 1 commit into
rashidrao-pk wants to merge 1 commit into
Conversation
Signed-off-by: Muhammad Rashid <muhammadrashid8045@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
fetch_tf_modelwhen used with newer versions of Keras.Recent versions of Keras no longer accept a full path passed through the
fnameargument oftf.keras.utils.get_file. Instead, the filename must be provided viafname, while the destination directory is specified usingcache_dir.This change updates
fetch_tf_modelaccordingly, preserving the existing download location while resolving theget_filepath error raised by newer Keras releases.Changes
tf.keras.utils.get_file.cache_dir.fetch_tf_modelcallsget_filewith the expected arguments.Testing
fetch_tf_model.ValueErrorreported in issue alibi-detect: utils: fetch: "Paths are no longer accepted as thefnameargument." #936 is resolved.Closes #936