Refactor drift detector score methods #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudvl
reviewed
Apr 27, 2022
arnaudvl
reviewed
Apr 27, 2022
|
Note that there are other detectors where the same change needs to be made (basically every detector doing a permutation test I think), e.g. learned kernel or LSDD. |
Ah yeh, I'll have a look at updating those too! |
ascillitoe
changed the title
|
@arnaudvl I think I've covered all the necessary detectors in the latest commits ( |
arnaudvl
approved these changes
May 18, 2022
Srceh
added a commit
to Srceh/alibi-detect
that referenced
this pull request
May 21, 2022
…IO#489). Merge branch 'master' into linear_time_mmd # Conflicts: # alibi_detect/cd/base.py # alibi_detect/cd/mmd.py # alibi_detect/cd/pytorch/mmd.py # alibi_detect/cd/tensorflow/mmd.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
distance_thresholdcomputation from.predict()to.score()methods, for all drift detectors that perform permutation tests.This simplifies detector
predictmethods, and aids consistency between the existingMMDDriftdetectors and the new linear-time MMD detectors introduced by #475.