Custom server container registry #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangonz
reviewed
Sep 5, 2022
There was a problem hiding this comment.
That's a great addition @saeid93! Thanks for contributing that one.
I've added a small comment below, but it would be great to hear your thoughts as well.
adriangonz
suggested changes
Sep 8, 2022
There was a problem hiding this comment.
Nice one! Changes look great @saeid93!
Just added a small comment flagging a typo, but everything else looks great! 👍
BTW you're able to check a live preview of the docs through the link below. The new Note block looks fantastic!
|
@adriangonz is it all good now? please let me know if anything else is needed. |
|
All looks good! Thanks for making the changes @saeid93 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #712