Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom server container registry #713

Merged
merged 7 commits into from
Sep 12, 2022

Conversation

saeid93
Copy link
Contributor

@saeid93 saeid93 commented Sep 2, 2022

solves #712

Copy link
Contributor

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great addition @saeid93! Thanks for contributing that one.

I've added a small comment below, but it would be great to hear your thoughts as well.

docs/examples/custom/README.md Show resolved Hide resolved
Copy link
Contributor

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Changes look great @saeid93!

Just added a small comment flagging a typo, but everything else looks great! 👍

BTW you're able to check a live preview of the docs through the link below. The new Note block looks fantastic!

https://mlserver--713.org.readthedocs.build/en/713/examples/custom/README.html#deploying-our-custom-image

image

docs/examples/custom/README.md Show resolved Hide resolved
@saeid93
Copy link
Contributor Author

saeid93 commented Sep 8, 2022

@adriangonz is it all good now? please let me know if anything else is needed.

@adriangonz
Copy link
Contributor

All looks good! Thanks for making the changes @saeid93 !

@adriangonz adriangonz merged commit b7dfe51 into SeldonIO:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants