Sherif akoush/quickfix/fix alibi import test #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at we only try to explain the first element of it.
� Conflicts: � docs/conf.py � mlserver/version.py � runtimes/alibi-detect/mlserver_alibi_detect/version.py � runtimes/alibi-explain/mlserver_alibi_explain/version.py � runtimes/lightgbm/mlserver_lightgbm/version.py � runtimes/mlflow/mlserver_mlflow/version.py � runtimes/mllib/mlserver_mllib/version.py � runtimes/sklearn/mlserver_sklearn/version.py � runtimes/xgboost/mlserver_xgboost/version.py
adriangonz
reviewed
Jan 17, 2022
setup.py
Outdated
| @@ -38,7 +38,8 @@ def _load_description() -> str: | |||
| "fastapi", | |||
| "grpcio", | |||
| "importlib-metadata;python_version<'3.8'", | |||
| "numpy", | |||
| # numba 0.55.0 requires: numpy <1.22 (for Shap / alibi) | |||
| "numpy==1.21.5", | |||
There was a problem hiding this comment.
Just wondering, would it work if we pinned the version of numpy in the dependencies of the Alibi runtime package?
There was a problem hiding this comment.
I didnt work for some reason but let me double check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pin
numpyto<1.22asnumba 0.55.0(alibi runtimeKernelShap) requires it.