build: Bump versions for Read the Docs #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't support Python `3.8` anymore. Poetry `1.8.1` matches what's currently in our Poetry lockfile. Building the docs is currently failing [1], and this ideally will fix that. [1] From readthedocs.org: ``` poetry install -vvv --without dev --with docs --with all-runtimes --with all-runtimes-dev Loading configuration file /home/docs/.config/pypoetry/config.toml The currently activated Python version 3.8.18 is not supported by the project (>=3.9,<3.12). Trying to find and use a compatible version. Trying python3 Trying python3.9 ```
There's still been some failures [2], so I've updated it to follow their recommendation [1]. [1] https://docs.readthedocs.io/en/stable/build-customization.html#install-dependencies-with-poetry [2] ``` Traceback (most recent call last): File "/home/docs/checkouts/readthedocs.org/user_builds/mlserver/envs/1761/lib/python3.10/site-packages/sphinx/config.py", line 509, in eval_config_file exec(code, namespace) # NoQA: S102 File "/home/docs/checkouts/readthedocs.org/user_builds/mlserver/checkouts/1761/docs/conf.py", line 19, in <module> import sphinx_material ModuleNotFoundError: No module named 'sphinx_material' ```
jesse-c
pushed a commit
that referenced
this pull request
May 16, 2024
* build: Bump versions for Read the Docs We don't support Python `3.8` anymore. Poetry `1.8.1` matches what's currently in our Poetry lockfile. Building the docs is currently failing [1], and this ideally will fix that. [1] From readthedocs.org: ``` poetry install -vvv --without dev --with docs --with all-runtimes --with all-runtimes-dev Loading configuration file /home/docs/.config/pypoetry/config.toml The currently activated Python version 3.8.18 is not supported by the project (>=3.9,<3.12). Trying to find and use a compatible version. Trying python3 Trying python3.9 ``` * docs: Bump copyright year * build: Use Python env for server * build: Use recommended Read the Docs setup There's still been some failures [2], so I've updated it to follow their recommendation [1]. [1] https://docs.readthedocs.io/en/stable/build-customization.html#install-dependencies-with-poetry [2] ``` Traceback (most recent call last): File "/home/docs/checkouts/readthedocs.org/user_builds/mlserver/envs/1761/lib/python3.10/site-packages/sphinx/config.py", line 509, in eval_config_file exec(code, namespace) # NoQA: S102 File "/home/docs/checkouts/readthedocs.org/user_builds/mlserver/checkouts/1761/docs/conf.py", line 19, in <module> import sphinx_material ModuleNotFoundError: No module named 'sphinx_material' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't support Python
3.8anymore.Poetry
1.8.1matches what's currently in our Poetry lockfile.Building the docs is currently failing [1], and this ideally will fix that.
[1] From readthedocs.org: