Refactor model wrapper #1056
Merged
Refactor model wrapper #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangonz
reviewed
Mar 24, 2023
mlserver/model_wrapper.py
Outdated
| ) | ||
|
|
||
|
|
||
| class WrapperMLModel(MLModel): |
There was a problem hiding this comment.
Do you remember why we needed this instead of just extending the MLModel class?
There was a problem hiding this comment.
It is essentially so that we have different implementations of MLModel where inner MLModel in this wrapper is created by a factory method and allowing the user to have in the model-settings.json one reference in implementation to this WrapperMLModel. For example in mlserver-alibi-explain runtime it is going to be AlibiExplainRuntime for ally types of alibi models.
There was a problem hiding this comment.
I simplified the code based on your suggestion to use __new__ instead
adriangonz
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the runtime wrapper to a common utility file.