Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alibi-explain runtime kernel_shap fixes #1017

Merged
merged 14 commits into from
Feb 28, 2023

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Feb 27, 2023

fixes #1008

This PR adds two extra optional configuration fields:

  • explainer_batch: whether an explainer can consume a batch (e.g. in the case of kernel_shap)
  • infer_output: allowing the user to specify which output to explain in the case of multi-output inference models

…/kernel_shap_fixes

# Conflicts:
#	runtimes/alibi-explain/mlserver_alibi_explain/explainers/black_box_runtime.py
Copy link
Contributor

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Added a couple comments, but I don't think they're within the scope of this PR.

@jklaise
Copy link

jklaise commented Feb 28, 2023

LGTM!

Copy link
Contributor

@RobertSamoilescu RobertSamoilescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sakoush sakoush merged commit 71da660 into SeldonIO:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to allow batch explanation
4 participants