Change comment to the right image format specification.#58
Open
alias512 wants to merge 1 commit intoSeeed-Studio:masterfrom
Open
Change comment to the right image format specification.#58alias512 wants to merge 1 commit intoSeeed-Studio:masterfrom
alias512 wants to merge 1 commit intoSeeed-Studio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation in the header file of the example BMP image is incorrect and misleading.
The header states:
Format: RGB565 (16-bit color)
This is incorrect. The actual encoding is 4 bits per pixel (bpp4), not 16-bit RGB565. Each byte represents two pixels, where each nibble (4 bits) corresponds to one pixel.
Example:
0x22 → first pixel = 0x2 (green), second pixel = 0x2 (green)
Additionally, the color representation is not standard RGB but uses indexed values:
0x0 = white
0x2 = green
0x6 = red
0xB = yellow
0xD = blue
0xF = black
The listed resolution (1200×1600) and the supported color set are correct, but the format description (RGB565, 16-bit) in the example BMP header file is wrong.