Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder files for PlatformIO to work with this lib and fix include paths #124

Open
wants to merge 4 commits into
base: arduino
Choose a base branch
from

Conversation

arduino12
Copy link

No description provided.

@Pillar1989
Copy link
Member

@arduino12 can you talk more about your PR ?

@arduino12
Copy link
Author

Hi,

Thanks for your quick response!
I love working with platformio, each project have platformio.ini configuration file,
This file can contain:

lib_deps =
    ${env.lib_deps_builtin}
    ${env.lib_deps_external}
    https://github.com/me-no-dev/ESPAsyncTCP.git
    knolleary/PubSubClient@^2.8
    paulstoffregen/OneWire

And pio takes care of cloning and including the repo into the Arduino environment!

But when using this lib or the one of elechouse, it only clones the PN532 folder - discarding the other PN532_* folders..

lib_deps =
    Wire
    SPI
    SoftwareSerial
    https://github.com/don/NDEF.git
    ; https://github.com/adafruit/Adafruit-PN532.git ; compiles
    ; https://github.com/Seeed-Studio/PN532.git      ; complain missing PN532_I2C.h and other headers
    ; https://github.com/elechouse/PN532.git         ; complain missing PN532_I2C.h and other headers
    https://github.com/arduino12/PN532.git           ; compiles (this is my PR)

I think it is related to a backward-compatibility stuff - old arduino libs structure:

|--PN532
  |--docs
  |--examples
  |--PN532
    |- PN532.c
    |- PN532.h

But now it need to be like:

|--PN532
  |--docs
  |--examples
  |--src
  |  |- PN532.c
  |  |- PN532.h
  |-- library.properties

Please see the files I changed and moved in my PR for full understanding-
now I can confirm my PR compiles with pio and works on my hardware :)

@MatthewJeffson MatthewJeffson added PN532 Label for PN532 UAY Unassigned yet Pull request Label for pull requests labels Oct 12, 2024
@Cincinnatu
Copy link

Hello. I will check soon whether this is effective and reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PN532 Label for PN532 Pull request Label for pull requests UAY Unassigned yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants