Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: major improvements with sequences #92

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Conversation

Seddryck
Copy link
Owner

  • sequences at resource and field levels
  • substition of sequences also for non-string fields
  • handling of null values

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 93.16239% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.61%. Comparing base (e154b5c) to head (fd88e49).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
PocketCsvReader/CsvDataReader.cs 85.00% 0 Missing and 3 partials ⚠️
PocketCsvReader/ArrayOfStringMapper.cs 0.00% 1 Missing ⚠️
...eader/Configuration/ImmutableSequenceCollection.cs 91.66% 1 Missing ⚠️
PocketCsvReader/CsvProfile.cs 90.90% 0 Missing and 1 partial ⚠️
PocketCsvReader/FieldParsing/SequenceSanitizer.cs 85.71% 0 Missing and 1 partial ⚠️
PocketCsvReader/NullableSpan.cs 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   82.23%   82.61%   +0.38%     
==========================================
  Files          48       58      +10     
  Lines        1396     1490      +94     
  Branches      250      274      +24     
==========================================
+ Hits         1148     1231      +83     
- Misses        175      176       +1     
- Partials       73       83      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Seddryck Seddryck force-pushed the feat/sequence-field-level branch from 0f2f99a to b628cb6 Compare January 11, 2025 21:14
- sequences at resource and field levels
- substition of sequences also for non-string fields
- handling of null values
@Seddryck Seddryck force-pushed the feat/sequence-field-level branch from b628cb6 to fd88e49 Compare January 11, 2025 21:26
@Seddryck Seddryck changed the title feat: major improvaments with sequences feat: major improvements with sequences Jan 11, 2025
@Seddryck Seddryck merged commit bf00be4 into main Jan 11, 2025
4 of 5 checks passed
@Seddryck Seddryck deleted the feat/sequence-field-level branch January 11, 2025 21:32
@Seddryck Seddryck added the new-feature Request for a new feature in the tool label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Request for a new feature in the tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants