Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parse with custom decimal and group chars for numeric values #86

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

Seddryck
Copy link
Owner

@Seddryck Seddryck commented Jan 5, 2025

No description provided.

@Seddryck Seddryck force-pushed the feat/number-format branch from 886b9c2 to 6e04425 Compare January 5, 2025 21:12
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 82.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.11%. Comparing base (08909f9) to head (6e04425).

Files with missing lines Patch % Lines
...CsvReader/Configuration/SchemaDescriptorBuilder.cs 40.00% 6 Missing ⚠️
PocketCsvReader/CsvDataReader.cs 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   82.06%   82.11%   +0.05%     
==========================================
  Files          46       48       +2     
  Lines        1355     1387      +32     
  Branches      243      248       +5     
==========================================
+ Hits         1112     1139      +27     
- Misses        171      175       +4     
- Partials       72       73       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Seddryck Seddryck merged commit 5e59a58 into main Jan 5, 2025
5 checks passed
@Seddryck Seddryck deleted the feat/number-format branch January 5, 2025 21:20
@Seddryck Seddryck added the new-feature Request for a new feature in the tool label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Request for a new feature in the tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants