Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a descriptor for the runtime type parser #113

Merged
merged 2 commits into from
Feb 9, 2025

Conversation

Seddryck
Copy link
Owner

@Seddryck Seddryck commented Feb 9, 2025

  • docs: review for all fluent APIs

- docs: review for all fluent APIs
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 74.35897% with 20 lines in your changes missing coverage. Please review.

Project coverage is 79.62%. Comparing base (973058e) to head (3e2f36b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...r/Configuration/RuntimeParsersDescriptorBuilder.cs 61.53% 2 Missing and 3 partials ⚠️
...svReader/Configuration/RuntimeParsersDescriptor.cs 60.00% 3 Missing and 1 partial ⚠️
PocketCsvReader/CsvDataRecord.cs 90.00% 1 Missing and 2 partials ⚠️
PocketCsvReader/FieldParsing/TypeIndexer.cs 62.50% 3 Missing ⚠️
PocketCsvReader/Configuration/CsvReaderBuilder.cs 60.00% 2 Missing ⚠️
...ader/Configuration/CustomFieldDescriptorBuilder.cs 0.00% 1 Missing ⚠️
...er/Configuration/IntegerFieldDescriptionBuilder.cs 0.00% 1 Missing ⚠️
...ader/Configuration/NumberFieldDescriptorBuilder.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   79.95%   79.62%   -0.33%     
==========================================
  Files          66       68       +2     
  Lines        1661     1703      +42     
  Branches      319      326       +7     
==========================================
+ Hits         1328     1356      +28     
- Misses        218      227       +9     
- Partials      115      120       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Seddryck Seddryck merged commit f2fcf59 into main Feb 9, 2025
5 checks passed
@Seddryck Seddryck deleted the feat/parser-configuration branch February 9, 2025 10:57
@Seddryck Seddryck added the new-feature Request for a new feature in the tool label Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Request for a new feature in the tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants