Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve handling of custom types #100

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Conversation

Seddryck
Copy link
Owner

No description provided.

@Seddryck Seddryck force-pushed the feat/improve-custom-type branch from c2619d3 to 7dd93f3 Compare January 19, 2025 20:46
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.82927% with 68 lines in your changes missing coverage. Please review.

Project coverage is 80.46%. Comparing base (f38bb45) to head (7dd93f3).

Files with missing lines Patch % Lines
...CsvReader/Configuration/SchemaDescriptorBuilder.cs 37.50% 25 Missing and 10 partials ⚠️
PocketCsvReader/CsvDataRecord.cs 67.44% 4 Missing and 10 partials ⚠️
PocketCsvReader/FormatDescriptorBuilder.cs 82.60% 4 Missing and 4 partials ⚠️
...er/Configuration/IntegerFieldDescriptionBuilder.cs 33.33% 4 Missing ⚠️
PocketCsvReader/CsvRawRecord.cs 0.00% 3 Missing ⚠️
...ader/Configuration/CustomFieldDescriptorBuilder.cs 66.66% 2 Missing ⚠️
...r/Configuration/TemporalFieldDescriptionBuilder.cs 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   82.34%   80.46%   -1.88%     
==========================================
  Files          60       65       +5     
  Lines        1484     1623     +139     
  Branches      278      307      +29     
==========================================
+ Hits         1222     1306      +84     
- Misses        172      209      +37     
- Partials       90      108      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Seddryck Seddryck merged commit 23268a1 into main Jan 19, 2025
4 of 5 checks passed
@Seddryck Seddryck deleted the feat/improve-custom-type branch January 19, 2025 20:53
@Seddryck Seddryck added the new-feature Request for a new feature in the tool label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Request for a new feature in the tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants