Skip to content

xByPartition argument order #8

@ijxy

Description

@ijxy

The proposed signature is

xByPartition(bytes32 _partition, <usual args for x>)

but this feels unintuitive because it should build on x, i.e., it is x with an extra argument to specify a parttion. Hence I would instead propose

xByPartition(<usual args for x>, bytes32 _parttion)

Although the above is explicitly targeted at the xByPartition functions, it applies equally to any functions that follow the xByY. So, generally, I am suggesting: xByY(<usual x args>, <y specific args>).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions