-
Notifications
You must be signed in to change notification settings - Fork 27
Some cleanup #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some cleanup #113
Conversation
|
Thank you very much for your contribution, but sadly we cannot merge the pull request like this because it has several issues:
If these issues are fixed, we can look at the actual content of this PR. One possibility would be about: Now write replace the line I hope I didn't scare you away, but things have to be and stay clean. If you are having problems cleaning up this PR, I can push those changes in your name into this PR. |
4a2d9bd to
b41a816
Compare
|
Thanks for the feedback and sorry for creating such a mess. |
|
This PR is a lot cleaner now and it is possible to see what have been done. Also the project structure is improved with the libraries folder. It seems, that you have extracted all the android sdk properties into the android_commons.gradle. Wouldn't it be possible to extract these from the app/build.gradle too? |
app/build.gradle
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some unneeded newline in this file.
|
Except from my line comments, this PR looks fine now 👍 |
|
I know that I'm nitpicking. Except for the unclean reverted commit, this PR should be ready to merge. |
|
I didn't saw the moved file in e7281a5. So reopened and merged. |
Hi @Doplgangr @L-Henke ,
I cleaned up the project structure a little :
PS : because the .iml files are not committed to source control, you will still see the *aFileChooser,payme &PreferenceFragment folders in the root of the project. To fix this I usually delete all the **.iml* files and the build directories and re-import the project in Android Studio.
PPS : I have also included fixes from the previuos pull requests: