This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
Added Captcha from DreckSoft plus changes in delivery options #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if it's your pull request or if ebay kleinanzeigen changed something again but neither the date_updated nor the id gets updated in the JSON. At least date_updated should not depend on the webpage. |
sebthom
reviewed
Nov 21, 2021
| try: | ||
| price = driver.find_element_by_xpath("//select[@name='priceType']/option[@value='%s']" % ad["price_type"]) | ||
| except NoSuchElementException: | ||
| raise Exception('Cannot find price type selection!') | ||
| price.click() |
There was a problem hiding this comment.
Either the indention of the new try/catch block is wrong or the indention of price.click().
Your change will result in a NameError: name 'price' is not defined in case price_type == 'GIVE_AWAY'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to DreckSoft, Added changes for captchas.
Plus correcting some delivery options.