Remove cchardet #67
Merged
Remove cchardet #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. This should have no effects on the actual package other than removing cchardet as a listed dependency, which should fix the Home assistant blockage. |
|
I'm on HA 2023.3.0 and this might fix the broken add on in this version of HA. Could someone merge this after testing? |
|
I will get a version pushed once I am back in front of the computer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here #66. and here SecKatie/ha-wyzeapi#462
HA is blocking cchardet in release 2023.3 as it's unmaintained and doesn't support Python 3.11. It doesn't appear that its used in the code so this removes it as a dependency to fix the conflict.