Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color mode property to bulbs #482

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

brg468
Copy link
Collaborator

@brg468 brg468 commented May 15, 2023

In response to #480:

Add the supported_color_mode and color_mode properties to light. Bulbs were always reporting their mode as Hue/Sat regardless of whether they were in color or white mode, which affected scenes. This should correct that functionality. Also fixes bulbs showing their last color in the frontend when the bulbs are in white.

@brg468 brg468 requested a review from SecKatie as a code owner May 15, 2023 19:14
@brg468 brg468 force-pushed the light-color-mode branch from e16f30c to 2b5af7e Compare May 15, 2023 19:20
@brg468 brg468 force-pushed the light-color-mode branch from 2b5af7e to 5a29ff4 Compare August 4, 2023 03:21
Copy link
Owner

@SecKatie SecKatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@SecKatie SecKatie merged commit e60f0e6 into SecKatie:master Aug 4, 2023
@SecKatie SecKatie mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants