Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update discord.js and electron & prettier code #231

Merged
merged 9 commits into from
Apr 19, 2023

Conversation

Xaliks
Copy link
Contributor

@Xaliks Xaliks commented Jan 14, 2023

Prettier
.js : prettier --write "**/*.js" --single-quote --tab-width=4
.html .css prettier --write "**/*.{css,html}" --tab-width=4

Discord.js
Updated discord.js to 14.9.0
Created custom <User|Channel>._typing caching

@SebOuellette
Copy link
Owner

I'm going to need to do some testing, but thanks for doing all this work! This looks very promising (as per usual @Xaliks)

@Xaliks Xaliks reopened this Apr 5, 2023
@SebOuellette
Copy link
Owner

SebOuellette commented Apr 18, 2023

Okay I'm testing it. I noticed that all the members in the list appear offline, and I can't set the playing/watching/listening status. Are these working on your end?

@SebOuellette
Copy link
Owner

SebOuellette commented Apr 18, 2023

Here's a screenshot of the member list still showing all members as offline
image

The activity status is working now :)

@SebOuellette
Copy link
Owner

Okay I found the issue, it was with the limit that was added to stop Livebot from lagging. Idk how, but it was just an if statement.. If you had too many members, none were displayed... I've updated it now to show only the first 100 members for each role, and it works now.

Copy link
Owner

@SebOuellette SebOuellette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice optimizations and formatting fixes :)

@SebOuellette SebOuellette merged commit aa45b48 into SebOuellette:master Apr 19, 2023
@Xaliks Xaliks deleted the update-discord branch April 20, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants