GRPackage>>#resolveWith: contains non-portable usage of String>>indexOfSubCollection:startingAt: #824
Description
What steps will reproduce the problem?
1. Execute GRPackage grPackages on VA Smalltalk
What is the expected output? What do you see instead?
The expected output is a collection of packages. On VA Smalltalk, we see a
walkback.
The cause of the walkback is this line in GRPackage>>#resolveWith:
(each indexOfSubCollection: '-Pharo-' startingAt: 0) ~= 0 ifTrue: [
The ANSI Smalltalk Standard states that it is an error if the starting index is
< 1. This is also an error in VA Smalltalk:
Primitive failed in: String>>#at: due to Index out of range in argument 1
Changing the line of code in GRPackage>>#resolveWith: to
(each indexOfSubCollection: '-Pharo-' startingAt: 1) ~= 0 ifTrue: [
corrects the problem on VA Smalltalk and does not affect the results of the
method on Pharo 2.0.
Original issue reported on code.google.com by wemb...@instantiations.com on 23 Aug 2014 at 2:51