-
-
Notifications
You must be signed in to change notification settings - Fork 223
Enable clippy::pedantic #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I think adding some panic docs is easiest right now. Converting panic to Error is not possible, unless ... we convert the API to return I honesty think we're running out of "innovation token" to make this change, but may be not! Another thought is instead of panicking, we return some syntatically incorrect SQL, it will end up as an error. |
I agree. It feels like we should be wrapping up this SeaQuery release soon and moving on to SeaORM-specific tasks.
Sounds weird. I'd keep the panics for now and figure it out later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still missing
# Errors
and# Panics
docs.
IMO, # Errors
would be useless noise in most cases. We should add # Panics
, though
7627db9
to
15db489
Compare
and typos
7f9a799
to
45d8355
Compare
39ff49d
to
b4e5e1e
Compare
This is ready to be merged. |
What about the semicolon check in CI? Looks good otherwise |
PR Info
Enable clippy::pedantic