Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace derivative by educe #763

Merged
merged 2 commits into from
Apr 14, 2024
Merged

Replace derivative by educe #763

merged 2 commits into from
Apr 14, 2024

Conversation

negezor
Copy link
Contributor

@negezor negezor commented Mar 31, 2024

PR Info

Digging into my Cargo.toml to get rid of syn v1, I saw that sea-query still depends indirectly through the derivative module. It hasn't been updated for a long time mcarton/rust-derivative#117. I found a more compact alternative to educe.

Changes

  • Replace derivative derive by educe for Value

@tyt2y3
Copy link
Member

tyt2y3 commented Apr 5, 2024

Thanks!

Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed a good solution

@tyt2y3 tyt2y3 merged commit 656e3aa into SeaQL:master Apr 14, 2024
Copy link

🎉 Released In 0.31.0-rc.5 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Copy link

github-actions bot commented Aug 9, 2024

🎉 Released In 0.31.0 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syn 1.x and 2.x both used in sea-query
2 participants