Skip to content

Add exists method to PaginatorTrait with tests #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: 1.1.x
Choose a base branch
from
Open

Add exists method to PaginatorTrait with tests #2623

wants to merge 4 commits into from

Conversation

IgnisDa
Copy link
Contributor

@IgnisDa IgnisDa commented Jun 13, 2025 •
edited
Loading

Introduce an exists method to the PaginatorTrait to efficiently check for record existence.

Fixes #730.

@Expurple
Copy link
Member

Thank you! I'll review this a bit later.

TODO for myself: also merge this in master (2.0.0).

If you're ok with using your own unreleased fork of 1.1.x until 2.0.0 comes out, you can change the base of the PR to master and we'll merge this only in master.

@IgnisDa
Copy link
Contributor Author

IgnisDa commented Jun 13, 2025 •
edited
Loading

Thank you! I'll review this a bit later.

TODO for myself: also merge this in master (2.0.0).

If you're ok with using your own unreleased fork of 1.1.x until 2.0.0 comes out, you can change the base of the PR to master and we'll merge this only in master.

Can this be released as a patch 1.1.x release? I think it should be fine since it does not have any breaking changes. That way I can continue to use the crates.io version.

@Expurple
Copy link
Member

Yeah, I assumed that you may want that. I'm not the one making (the decisions about) releases, but @tyt2y3 will probably do this

IgnisDa
IgnisDa commented Jun 16, 2025
View reviewed changes
tests/common/bakery_chain/seed_data.rs
bakery_id: Set(42),
customer_id: Set(11),
placed_at: Set(DateTime::UNIX_EPOCH),
placed_at: Set(ChronoDateTime::UNIX_EPOCH.naive_utc()),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did this because this was throwing a deprecation warning

Expurple
Expurple approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@Expurple Expurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Everything looks good to me!

@tyt2y3. we can merge this and then cherry-pick into master too

@Expurple Expurple requested a review from tyt2y3 July 29, 2025 14:16
@IgnisDa
Copy link
Contributor Author

IgnisDa commented Aug 5, 2025

@tyt2y3 Can you take a look at this please? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Expurple Expurple Expurple approved these changes

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IgnisDa @Expurple