cli: Implement MigrationName for Migration in migration generation
#2580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Huliiiiii
force-pushed
the
impl-migration-name-in-generation
branch
from
912fe94 to
8f19128
Compare
Huliiiiii
commented
Apr 23, 2025
| impl MigrationName for Migration {{ | ||
| fn name(&self) -> &str {{ | ||
| "{migration_name}" |
There was a problem hiding this comment.
Should we check for invalid input?
Huliiiiii
changed the title
MigrationName in migration generationMigrationName for Migration in migration generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
A better solution of #2566.
Make migration names independent of file name to support different file structures.
I also cleaned up the migration template.
New Features
Bug Fixes
Breaking Changes
Changes