Dev type supports #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manage sequences as list
Signed-off-by: David Pierret <david.pierret@smile.fr>
Signed-off-by: David Pierret <david.pierret@smile.fr>
Add basic support for publisher know issue : Segfault after write() call Signed-off-by: David Pierret <david.pierret@smile.fr>
manage sequences as list
Signed-off-by: David Pierret <david.pierret@smile.fr>
Signed-off-by: David Pierret <david.pierret@smile.fr>
Signed-off-by: David Pierret <david.pierret@smile.fr>
Signed-off-by: David Pierret <david.pierret@smile.fr>
Signed-off-by: David Pierret <david.pierret@smile.fr>
Signed-off-by: David Pierret <david.pierret@smile.fr>
Signed-off-by: David Pierret <david.pierret@smile.fr>
- Fix cpp issue where topic_types_ private member was accessed by derived class. - Fix DataWriter python class issue where the datawriter used datareader_wait_for cpp binding.
- DataWriter and Publisher classes should not have a listener member. - QoS still can be passed, but QOS_DEFAULTs are always used in cpp binding methods.
- Dash separation in label will be deprecated, use underscore instead
- DataWriter and DataReader wait_for methods does not use WaitSet dispatch. A simple while loop is used to check status conditions, and the STL current thread sleep is used to wait. - DataRead take_next_sample does not perform his own wait but try immediately perform library call to take_next_sample.
- When checking limits of floating value with cpp STL library, min() returns the minimum positive representable value, lowest() must be used instead.
- Each supported type defined in IDL imports now the whole module name at once (importing the root and browsing into submodules resulted into a NULL value and an exception).
- When a module has a type which is defined into a parent module, the type is not found. Imports are now done properly. - To investigate: Two Exceptions are now disabled in cpp bindings because the conditions seems not be required.
- DomainParticipant pointers were created with a factory, and then deleted with the help of SharedPointer (aliased to DomainParticipant_var). Mixing rough ptrs and shared ptrs causes troubles and the factory should now be responsible for the deletion of the participants.
- The IDL generated classes use Polymorphism (e.g: sequence type that directly derived from list). A simple call to Py_IsInstance() was not suffiscient and the exception was thrown (and unhandled) even though the case of the derived class should work.
- separate user.hpp and common.hpp into subfiles. - cpp/hpp files use now four spaces indentation
- DecRef the TypeSupport_var object instead of calling direct delete. - Import _pyopendds c bindings (and try-catch ImportError) in top level instead of __del__, because dynamically loaded modules are likely to be unavailable at terminate.
c_ubyte and c_byte are wrapped into UByte and Byte custom python classes.
…ice and bool was missing.
Signed-off-by: David Pierret <david.pierret@smile.fr>
…Supports # Conflicts: # pyopendds/dev/include/pyopendds/user.hpp
…Supports # Conflicts: # pyopendds/DataWriter.py # pyopendds/Publisher.py # pyopendds/dev/include/pyopendds/user.hpp # pyopendds/dev/itl2py/CppOutput.py # pyopendds/dev/itl2py/PythonOutput.py # pyopendds/dev/itl2py/ast.py # pyopendds/dev/itl2py/templates/user.cpp # pyopendds/dev/itl2py/templates/user.py # pyopendds/ext/_pyopendds.cpp # tests/basic_test/publisher.py
…Supports # Conflicts: # pyopendds/dev/include/pyopendds/user.hpp
(Reverse commit so that we mark the merging resolved as rejected).
|
Take all from dev_TypeSupports when resolving. There is one last conflict that was not detected in ext/_pyopendds.cpp: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for: