Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform/image-processor): allow http downloads on image processor #188

Merged
merged 4 commits into from
Jan 13, 2024

Conversation

TroyKomodo
Copy link
Member

Proposed changes

Allow for the input path to be an http url which the image processor will fetch when processing the image.

Types of changes

What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, you may want to start the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.

Allow for the input path to be an http url which the image processor
will fetch when processing the image.
@TroyKomodo TroyKomodo requested a review from a team as a code owner January 13, 2024 20:05
@TroyKomodo TroyKomodo requested review from lennartkloock and removed request for a team January 13, 2024 20:06
Copy link
Contributor

@4w3Official 4w3Official left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (52ac456) 46.72% compared to head (4784778) 46.70%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/website     #188      +/-   ##
===================================================
- Coverage            46.72%   46.70%   -0.02%     
===================================================
  Files                  486      486              
  Lines                30818    30831      +13     
===================================================
+ Hits                 14399    14401       +2     
- Misses               16419    16430      +11     
Files Coverage Δ
common/src/task.rs 79.16% <100.00%> (+0.12%) ⬆️
platform/image_processor/src/processor/error.rs 0.00% <ø> (ø)
...mage_processor/src/processor/job/decoder/ffmpeg.rs 82.85% <100.00%> (+0.12%) ⬆️
platform/image_processor/src/config.rs 0.00% <0.00%> (ø)
platform/image_processor/src/processor/job/mod.rs 0.00% <0.00%> (ø)

@TroyKomodo TroyKomodo changed the title feat: allow http downloads on image processor feat(platform/image_processor): allow http downloads on image processor Jan 13, 2024
@TroyKomodo TroyKomodo added the platform/image-processor Issues related to the Platform Image Processor label Jan 13, 2024
@TroyKomodo TroyKomodo changed the title feat(platform/image_processor): allow http downloads on image processor feat(platform/image-processor): allow http downloads on image processor Jan 13, 2024
@TroyKomodo TroyKomodo merged commit cf18151 into feature/website Jan 13, 2024
7 of 9 checks passed
@TroyKomodo TroyKomodo deleted the troy/image-processor-http branch January 13, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/image-processor Issues related to the Platform Image Processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants