Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI #171

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Add CI #171

merged 1 commit into from
Dec 29, 2023

Conversation

TroyKomodo
Copy link
Member

Proposed changes

Add CI

Types of changes

What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, you may want to start the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 784 lines in your changes are missing coverage. Please review.

Comparison is base (fa5418c) 73.83% compared to head (6c71249) 53.51%.
Report is 38 commits behind head on feature/website.

❗ Current head 6c71249 differs from pull request most recent head 721c9d0. Consider uploading reports for the commit 721c9d0 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                  @@
##           feature/website     #171       +/-   ##
====================================================
- Coverage            73.83%   53.51%   -20.32%     
====================================================
  Files                  221      441      +220     
  Lines                17608    26792     +9184     
====================================================
+ Hits                 13000    14339     +1339     
- Misses                4608    12453     +7845     
Files Coverage Δ
common/src/context.rs 100.00% <100.00%> (ø)
common/src/dataloader/batch_loader.rs 100.00% <100.00%> (ø)
common/src/global.rs 100.00% <100.00%> (ø)
common/src/prelude/futures.rs 100.00% <100.00%> (ø)
config/config/src/key.rs 75.08% <ø> (+0.26%) ⬆️
config/config/src/lib.rs 78.14% <ø> (+0.30%) ⬆️
config/config/src/primitives.rs 45.31% <ø> (-10.89%) ⬇️
config/config/src/sources/cli.rs 88.96% <ø> (+5.03%) ⬆️
config/config/src/sources/env.rs 86.17% <ø> (+8.39%) ⬆️
config/config/src/sources/file/json.rs 69.56% <ø> (ø)
... and 24 more

... and 549 files with indirect coverage changes

@TroyKomodo TroyKomodo marked this pull request as ready for review December 29, 2023 16:23
@TroyKomodo TroyKomodo requested review from a team as code owners December 29, 2023 16:23
Copy link
Contributor

@SputNikPlop SputNikPlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not familiar enough with the docker part though

In adding the CI we test deployed and noticed a few bugs in video
section:

This commit also fixes those bugs related to
- Fixes h264/h265 decoding issue.
- Fixes FFmpeg race condition in transcoder
- Fixes Logic issues with private rooms on edge
- Feat optionally specify a CA Cert

We also added docker images for all the target binaries.
@TroyKomodo TroyKomodo merged commit 7e483f0 into feature/website Dec 29, 2023
4 of 7 checks passed
@TroyKomodo TroyKomodo deleted the troy/ci branch December 29, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants