-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): about page #165
Merged
lennartkloock
merged 22 commits into
ScuffleTV:feature/website
from
lennartkloock:lennartkloock/about-page
Jan 17, 2024
Merged
feat(website): about page #165
lennartkloock
merged 22 commits into
ScuffleTV:feature/website
from
lennartkloock:lennartkloock/about-page
Jan 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TroyKomodo
force-pushed
the
lennartkloock/about-page
branch
from
December 21, 2023 22:15
774f99d
to
55947d3
Compare
TroyKomodo
force-pushed
the
lennartkloock/about-page
branch
2 times, most recently
from
January 1, 2024 02:14
b8aeef4
to
1f257c5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/website #165 +/- ##
===================================================
- Coverage 46.72% 46.70% -0.02%
===================================================
Files 486 486
Lines 30818 30831 +13
===================================================
+ Hits 14399 14401 +2
- Misses 16419 16430 +11 |
TroyKomodo
force-pushed
the
lennartkloock/about-page
branch
from
January 1, 2024 22:58
1f257c5
to
baa7aa3
Compare
lennartkloock
force-pushed
the
lennartkloock/about-page
branch
2 times, most recently
from
January 17, 2024 00:54
0dd1e56
to
0fad1d0
Compare
lennartkloock
force-pushed
the
lennartkloock/about-page
branch
from
January 17, 2024 21:53
e1037d9
to
acbfcc4
Compare
TroyKomodo
approved these changes
Jan 17, 2024
SputNikPlop
approved these changes
Jan 17, 2024
lennartkloock
merged commit Jan 17, 2024
9e1a880
into
ScuffleTV:feature/website
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implements about page like designed on Figma.
Types of changes
What types of changes does your code introduce to Scuffle?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Closes #166