Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): about page #165

Merged

Conversation

lennartkloock
Copy link
Member

@lennartkloock lennartkloock commented Dec 14, 2023

Proposed changes

Implements about page like designed on Figma.

Types of changes

What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Closes #166

@TroyKomodo TroyKomodo force-pushed the lennartkloock/about-page branch 2 times, most recently from b8aeef4 to 1f257c5 Compare January 1, 2024 02:14
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52ac456) 46.72% compared to head (67f2a9f) 46.70%.
Report is 7 commits behind head on feature/website.

❗ Current head 67f2a9f differs from pull request most recent head 5b7daa8. Consider uploading reports for the commit 5b7daa8 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/website     #165      +/-   ##
===================================================
- Coverage            46.72%   46.70%   -0.02%     
===================================================
  Files                  486      486              
  Lines                30818    30831      +13     
===================================================
+ Hits                 14399    14401       +2     
- Misses               16419    16430      +11     

see 4 files with indirect coverage changes

@TroyKomodo TroyKomodo added the platform/website Issues related to the Platform Website label Jan 2, 2024
@lennartkloock lennartkloock force-pushed the lennartkloock/about-page branch 2 times, most recently from 0dd1e56 to 0fad1d0 Compare January 17, 2024 00:54
@lennartkloock lennartkloock marked this pull request as ready for review January 17, 2024 21:54
@lennartkloock lennartkloock requested a review from a team as a code owner January 17, 2024 21:54
@lennartkloock lennartkloock requested a review from a team as a code owner January 17, 2024 21:54
@lennartkloock lennartkloock merged commit 9e1a880 into ScuffleTV:feature/website Jan 17, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/website Issues related to the Platform Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About page
3 participants