Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webite): fix some css #111

Merged
merged 3 commits into from
Jul 23, 2023
Merged

fix(webite): fix some css #111

merged 3 commits into from
Jul 23, 2023

Conversation

lennartkloock
Copy link
Member

@lennartkloock lennartkloock commented Jul 22, 2023 •
edited
Loading

Proposed changes

  • Fixed the side bar. It was buggy in Firefox before because the avatar width wasn't limited.
  • Fixed some spacing issues related to stream previews.
  • Fixed spelling.

Types of changes

What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@lennartkloock
fix: side bar in firefox
63ef6ab 
The side bar was buggy in firefox before
because the avatar width wasn't limited
@lennartkloock lennartkloock requested review from a team as code owners July 22, 2023 22:50
@lennartkloock
fix: some spacing issues
f161e09 
Fix some spacing issues in the stream preview
@lennartkloock lennartkloock changed the title fix: side bar in firefox fix(webite): fix some css Jul 23, 2023
@lennartkloock
fix(website): spelling
1bbee51 
Fix spelling of "Log in"
@TroyKomodo
Copy link
Member

ill try it out!

@TroyKomodo TroyKomodo merged commit 4be23ea into ScuffleTV:troy/clean-up Jul 23, 2023
1 of 2 checks passed
@lennartkloock lennartkloock deleted the lennart/fix-side-bar branch July 31, 2023 19:23
lennartkloock added a commit to lennartkloock/scuffle that referenced this pull request Aug 21, 2023
@lennartkloock
fix(webite): fix some css (ScuffleTV#111)
73967a9 
* fix: side bar in firefox

The side bar was buggy in firefox before
because the avatar width wasn't limited

* fix: some spacing issues

Fix some spacing issues in the stream preview

* fix(website): spelling

Fix spelling of "Log in"
TroyKomodo pushed a commit that referenced this pull request Aug 22, 2023
@lennartkloock @TroyKomodo
fix(webite): fix some css (#111)
a9fc626 
* fix: side bar in firefox

The side bar was buggy in firefox before
because the avatar width wasn't limited

* fix: some spacing issues

Fix some spacing issues in the stream preview

* fix(website): spelling

Fix spelling of "Log in"
TroyKomodo added a commit that referenced this pull request Aug 24, 2023
@TroyKomodo
feat: website cleanup
2ad0bfe 
fix(webite): fix some css (#111)

* fix: side bar in firefox

The side bar was buggy in firefox before
because the avatar width wasn't limited

* fix: some spacing issues

Fix some spacing issues in the stream preview

* fix(website): spelling

Fix spelling of "Log in"

fix(website): add sidenav animation

Add side-nav animation and cleanup code

fix(website): make topnav a flexbox

Convert topnav from grid to flex

feat(website): improve search bar

Improve search bar by making the icon a button and adding a form

fix(website): clean up topnav css

Clean up topnav css by using flexbox features
instead of hardcoded width and height values.
This also makes it more responsive.

feat(website): add show more button

Add show more button after stream previews and clean up some more css

feat(website): category cards

Add category cards to home page
lennartkloock pushed a commit to lennartkloock/scuffle that referenced this pull request Aug 24, 2023
@TroyKomodo @lennartkloock
feat: website cleanup
2d2e57b 
fix(webite): fix some css (ScuffleTV#111)

* fix: side bar in firefox

The side bar was buggy in firefox before
because the avatar width wasn't limited

* fix: some spacing issues

Fix some spacing issues in the stream preview

* fix(website): spelling

Fix spelling of "Log in"

fix(website): add sidenav animation

Add side-nav animation and cleanup code

fix(website): make topnav a flexbox

Convert topnav from grid to flex

feat(website): improve search bar

Improve search bar by making the icon a button and adding a form

fix(website): clean up topnav css

Clean up topnav css by using flexbox features
instead of hardcoded width and height values.
This also makes it more responsive.

feat(website): add show more button

Add show more button after stream previews and clean up some more css

feat(website): category cards

Add category cards to home page

Fix contribution attributions
lennartkloock pushed a commit to lennartkloock/scuffle that referenced this pull request Aug 24, 2023
@TroyKomodo @lennartkloock
feat: website cleanup
26ee8e0 
fix(webite): fix some css (ScuffleTV#111)

* fix: side bar in firefox

The side bar was buggy in firefox before
because the avatar width wasn't limited

* fix: some spacing issues

Fix some spacing issues in the stream preview

* fix(website): spelling

Fix spelling of "Log in"

fix(website): add sidenav animation

Add side-nav animation and cleanup code

fix(website): make topnav a flexbox

Convert topnav from grid to flex

feat(website): improve search bar

Improve search bar by making the icon a button and adding a form

fix(website): clean up topnav css

Clean up topnav css by using flexbox features
instead of hardcoded width and height values.
This also makes it more responsive.

feat(website): add show more button

Add show more button after stream previews and clean up some more css

feat(website): category cards

Add category cards to home page

Fix contribution attribution
lennartkloock added a commit to lennartkloock/scuffle that referenced this pull request Aug 24, 2023
@lennartkloock
feat: website cleanup
adea4ac 
fix(webite): fix some css (ScuffleTV#111)

* fix: side bar in firefox

The side bar was buggy in firefox before
because the avatar width wasn't limited

* fix: some spacing issues

Fix some spacing issues in the stream preview

* fix(website): spelling

Fix spelling of "Log in"

fix(website): add sidenav animation

Add side-nav animation and cleanup code

fix(website): make topnav a flexbox

Convert topnav from grid to flex

feat(website): improve search bar

Improve search bar by making the icon a button and adding a form

fix(website): clean up topnav css

Clean up topnav css by using flexbox features
instead of hardcoded width and height values.
This also makes it more responsive.

feat(website): add show more button

Add show more button after stream previews and clean up some more css

feat(website): category cards

Add category cards to home page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SputNikPlop SputNikPlop SputNikPlop approved these changes

@TroyKomodo TroyKomodo Awaiting requested review from TroyKomodo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lennartkloock @TroyKomodo @SputNikPlop