Conversation
Bilge
force-pushed
the
transform
branch
3 times, most recently
from
d5b11bd to
493d364
Compare
Added Transformer interface. Refactored filter code into FilterTransformer. Removed filters and mappings from Porter and ImportSpecification. Updated tests.
Split transformation in Porter into separate method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completely decouples filtering and mapping from both
PorterandImportSpecificationusing the newTransformerinterface. Filtering support is still provided with the newFilterTransformersince it is lightweight and often required whilst mapping has been moved to a separate project, MappingTransformer, which can be required as needed.The
Transformerinterface represents post-import data transformation operations and can be implemented by any library wishing to plug in to Porter to provide such transformations. For example, this interface could be used for the proposed hydration and/or validation features in future without requiring any modifications to Porter.Transformerinterface.Transformersupport toPorter::importandImportSpecification.PorterintoFilterTransformer.PorterandImportSpecification.