38 Optimize Endpoint Generator#41
Merged
Merged
Conversation
ewilliams0305
commented
Sep 18, 2025
| .Select(static (type, _) => TransformHandlerType(type!.Value)) | ||
| .WithComparer(TargetMethodCaptureContextComparer.Instance); | ||
| IncrementalValueProvider<ImmutableArray<CapturedHandler>> getHandlers = context.SyntaxProvider.ForAttributeWithMetadataName( | ||
| GetEndpointAttribute.TypeFullName, |
Contributor
Author
There was a problem hiding this comment.
Ideally I would capture every endpoint handler using the EndpointAttribute base then later determine its derrived type and use that information for the Verb. There would be no need to combine these arrays and reconstruct the Tuples below
| IncrementalValuesProvider<TargetMethodCaptureContext> endpointProvider = | ||
| combinedEndpointArrays.SelectMany(static (tuple, _) => | ||
| { | ||
| var (((gets, posts), puts), deletes) = tuple; |
Contributor
Author
There was a problem hiding this comment.
this is a bit too gnarly for my taste
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scribbly Pull Request
Description
This PR takes advantage of Roslyn APIs used to located specific Attribute Annotations and reduces the query mechanics required to located endpoint method handlers.
context.SyntaxProvider.ForAttributeWithMetadataNameAfter initial testing the generator seems much faster and will only improve more when Groups are updated as well.
Type of change
Checklist
Github Issues
closes #39