Skip to content

Fix macOS installer and paths (#16251) - #8532

Open
Cid-oe wants to merge 1 commit into
Scottcjn:mainfrom
Cid-oe:fix/install-script
Open

Cid-oe wants to merge 1 commit into
Scottcjn:mainfrom
Cid-oe:fix/install-script

Conversation

@Cid-oe

@Cid-oe Cid-oe commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Resolves Scottcjn/rustchain-bounties#16251

Fixes #7975

Changes:

  • Fixed incorrect paths for macOS miner versions (selects v2.4.py for Intel x86_64 and v2.5.py for Apple Silicon arm64).
  • Added strict OS detection to fail loudly and prevent half-installation on unsupported platforms (like FreeBSD or Windows).
  • Cleaned up OS checks and package manager assumptions (brew is used for macOS python installation).
  • Addressed all POSIX compliance issues. Shellcheck now passes with absolutely zero errors.
  • Checked there is no usage of GNU-only commands like sed -i or grep -P.

Testing Evidence:

  • Tested shellcheck on both install.sh and scripts/install.sh. Passed cleanly.
  • Verified platform detection conditions cover macOS variations appropriately.

- Resolves Scottcjn/rustchain-bounties#16251
- Fixes Scottcjn#7975
- Use proper v2.4.py miner for Intel macOS, v2.5.py for arm64
- Ensure zero bash warnings (shellcheck passes)
- Prevent half-installations on unsupported platforms
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to RustChain! Thanks for your first pull request.

Before we review, please make sure:

  • Non-doc PRs have a BCOS-L1 or BCOS-L2 label
  • Doc-only PRs are exempt from BCOS tier labels when they only touch docs/**, *.md, or common image/PDF files
  • New code files include an SPDX license header
  • You've tested your changes against the live node

Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150)

A maintainer will review your PR soon. Thanks for contributing!

@github-actions github-actions Bot added BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) size/M PR: 51-200 lines labels Sep 28, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) size/M PR: 51-200 lines

Projects

None yet

1 participant