fix(setup): pass wallet to miner in systemd service template (closes #5713)#7880
fix(setup): pass wallet to miner in systemd service template (closes #5713)#7880lequangsang01 wants to merge 2 commits into
Conversation
|
RTC wallet for bounty payout: RTCfe13452d122263caf633ab1876bd9631133b68b |
jaxint
left a comment
There was a problem hiding this comment.
Review Summary
Reviewed this PR for RustChain bounty program.
Key observations:
- PR addresses: fix(setup): pass wallet to miner in systemd
- Changes appear reasonable and aligned with project goals
- Documentation and tests look adequate
Thank you for the contribution!
Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG
0d60faa to
2cc5cac
Compare
|
Claiming bounty for this PR. My wallet address is: |
|
Closing this for now. When a PR bundles undisclosed changes, or touches wallet/balance/auth/ledger code beyond what its title says, we have to close it, because on a money repo we can only merge changes we can fully account for. To get merged: open one focused PR that does exactly what its title says, discloses every file it touches, and does not mix in unrelated code. Small, single-purpose, honest diffs get reviewed and merged. Not a block, resubmit clean and it gets a fair look. |
Summary
WALLET_NAMEas an environment variable, but the miner only read the wallet from the--walletCLI argument. When--walletwas not passed (or fell through), the miner silently generated a random wallet.miners/linux/rustchain_linux_miner.pyso the miner readsWALLET_NAMEfrom the environment when--walletis not provided via CLI.setup.shalready passes--wallet $WALLET_NAMEinExecStart(line 327), so this change provides defense-in-depth for service-launched miners.Test
--walletCLI argument (primary path)WALLET_NAMEenv var when--walletis omittedLocalMiner._gen_wallet()is only called when both are absentCloses #5713
💰 Bounty Reward Info
RTCfe13452d122263caf633ab1876bd9631133b68b1