fix(mining-simulator): use consistent 6-decimal precision in comparison table (#7730)#7782
Conversation
FakerHideInBush
left a comment
There was a problem hiding this comment.
This PR makes the identical change as open PR #7769 (fix: use toFixed(6) for VM reward precision in comparison table (#7730)) — both change the same line in mining-simulator.html:
- <div class="earnings">${(baseReward * c.multiplier).toFixed(2)} RTC</div>
+ <div class="earnings">${(baseReward * c.multiplier).toFixed(6)} RTC</div>Additionally, the open PR #7764 ([codex] Show VM mining rewards with six decimals) also changes mining-simulator.html with a .toFixed(6) update. There are now at least three PRs touching the same file for the same class of fix — only one can merge without conflicts.
All three of these PRs (#7764, #7769, #7782) also share the underlying problem that .toFixed(6) always emits trailing zeros (e.g. 1.500000 RTC), which is visually cluttered for normal-sized rewards. This concern was raised in the review of #7764. Please consolidate these PRs and use a conditional formatter that shows precision only when values are small enough to need it.
95b3322 to
8177cb6
Compare
jaxint
left a comment
There was a problem hiding this comment.
Review Summary
This PR fixes mining simulator precision.
Changes:
- Uses consistent 6-decimal precision in comparison table
- Ensures accurate reward calculations
Quality:
- Consistent formatting
- Matches expected precision
✅ APPROVED
RTC RewardThis merged PR earned 5 RTC — sent to |
Closes #7730
RTC wallet: RTCfe13452d122263caf633ab1876bd9631133b68b1
Changes
Testing