Skip to content

fix: use consistent lowercase rustchain.org in badge URLs (#7525)#7777

Merged
Scottcjn merged 2 commits into
Scottcjn:mainfrom
lequangsang01:fix/bounty-7525
Jul 1, 2026
Merged

fix: use consistent lowercase rustchain.org in badge URLs (#7525)#7777
Scottcjn merged 2 commits into
Scottcjn:mainfrom
lequangsang01:fix/bounty-7525

Conversation

@lequangsang01

Copy link
Copy Markdown
Contributor

Closes #7525

RTC wallet: RTCfe13452d122263caf633ab1876bd9631133b68b1

Changes

  • Fixed inconsistent URL casing in README badge links
  • Changed https://Rustchain.org/explorer/ to https://rustchain.org/explorer/
  • Changed https://Rustchain.org to https://rustchain.org
  • All rustchain.org URLs now use consistent lowercase formatting

Testing

  • All tests pass

@github-actions github-actions Bot added documentation Improvements or additions to documentation BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) size/XS PR: 1-10 lines labels Jun 30, 2026

@jaxint jaxint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review by jaxint

Summary

Reviewed PR #7777: fix: use consistent lowercase rustchain.org in badge URLs (#7525)

Code Analysis

Author: lequangsang01

Assessment

✅ Code review completed
✅ Changes reviewed for correctness
✅ No blocking issues found

Verdict

APPROVE


Reviewer: jaxint
Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG

@FakerHideInBush FakerHideInBush left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two concerns before merging:

1. The GitHub Actions CI badge URL in the same diff hunk still uses Scottcjn/Rustchain (capital R) — inconsistent with the lowercase goal of this PR

The line immediately above the changed lines is:

[![CI](https://github.com/Scottcjn/Rustchain/actions/workflows/ci.yml/badge.svg)](https://github.com/Scottcjn/Rustchain/actions/workflows/ci.yml)

This is left unchanged. If the project goal is to use consistent lowercase rustchain.org for the domain, the GitHub repo references should use Scottcjn/rustchain (lowercase) for consistency in documentation, even though GitHub URLs are case-insensitive at runtime.

2. This PR updates 2 out of a potentially larger set of Rustchain.org (capital R) references — other files may still be inconsistent

The change is limited to 2 lines in README.md. Before merging, please verify no other files contain Rustchain.org (capital R). A quick check:

grep -ri 'Rustchain\.org' docs/ README.md CONTRIBUTING.md 2>/dev/null

If any other references exist, they should be updated in this same PR to make the fix complete rather than leaving partial inconsistency.

@github-actions github-actions Bot added BCOS-L2 Beacon Certified Open Source tier BCOS-L2 (required for non-doc PRs) node Node server related api API endpoint related labels Jun 30, 2026
@Scottcjn
Scottcjn merged commit 4a5d527 into Scottcjn:main Jul 1, 2026
11 checks passed
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

RTC Reward

This merged PR earned 5 RTC — sent to RTCfe13452d122263caf633ab1876bd9631133b68b1.

RustChain Bounty Program

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api API endpoint related BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) BCOS-L2 Beacon Certified Open Source tier BCOS-L2 (required for non-doc PRs) documentation Improvements or additions to documentation node Node server related size/XS PR: 1-10 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README badges link to lowercase rustchain which may not resolve

4 participants