fix: use consistent lowercase rustchain.org in badge URLs (#7525)#7777
Conversation
jaxint
left a comment
There was a problem hiding this comment.
PR Review by jaxint
Summary
Reviewed PR #7777: fix: use consistent lowercase rustchain.org in badge URLs (#7525)
Code Analysis
Author: lequangsang01
Assessment
✅ Code review completed
✅ Changes reviewed for correctness
✅ No blocking issues found
Verdict
APPROVE ✅
Reviewer: jaxint
Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG
FakerHideInBush
left a comment
There was a problem hiding this comment.
Two concerns before merging:
1. The GitHub Actions CI badge URL in the same diff hunk still uses Scottcjn/Rustchain (capital R) — inconsistent with the lowercase goal of this PR
The line immediately above the changed lines is:
[](https://github.com/Scottcjn/Rustchain/actions/workflows/ci.yml)This is left unchanged. If the project goal is to use consistent lowercase rustchain.org for the domain, the GitHub repo references should use Scottcjn/rustchain (lowercase) for consistency in documentation, even though GitHub URLs are case-insensitive at runtime.
2. This PR updates 2 out of a potentially larger set of Rustchain.org (capital R) references — other files may still be inconsistent
The change is limited to 2 lines in README.md. Before merging, please verify no other files contain Rustchain.org (capital R). A quick check:
grep -ri 'Rustchain\.org' docs/ README.md CONTRIBUTING.md 2>/dev/nullIf any other references exist, they should be updated in this same PR to make the fix complete rather than leaving partial inconsistency.
RTC RewardThis merged PR earned 5 RTC — sent to |
Closes #7525
RTC wallet: RTCfe13452d122263caf633ab1876bd9631133b68b1
Changes
https://Rustchain.org/explorer/tohttps://rustchain.org/explorer/https://Rustchain.orgtohttps://rustchain.orgTesting