fix: unify Critical bounty tier range to match README (#7683)#7774
Conversation
jaxint
left a comment
There was a problem hiding this comment.
PR Review by jaxint
Summary
Reviewed PR #7774: fix: unify Critical bounty tier range to match README (#7683)
Code Analysis
Changes: 593 bytes of diff
Author: lequangsang01
Assessment
✅ Code review completed
✅ Changes reviewed for correctness
✅ No blocking issues found
Verdict
APPROVE ✅
The changes appear correct and well-implemented.
Reviewer: jaxint
Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG
FakerHideInBush
left a comment
There was a problem hiding this comment.
Two concerns before merging:
1. After this change the Major and Critical tier ranges overlap at exactly 100 RTC
Current QUICKSTART.md after this PR:
| Major | 75–100 RTC | ... |
| Critical | 100–150 RTC | ... |
A bounty worth exactly 100 RTC satisfies both tier definitions. The overlap doesn't exist in the README (which this PR intends to match), so please verify the README uses half-open intervals or otherwise disambiguates the boundary — and replicate that clarification in QUICKSTART.md. For example:
| Major | 75–99 RTC |
| Critical | 100–150 RTC |
2. The search scope of this PR is limited to one file — if 100-200 RTC or 100–200 RTC appears in other documentation or source files, those are left inconsistent
Before merging, please verify no other files reference the old 100-200 range. Common locations to check:
README.md(the source of truth this PR cites)CONTRIBUTING.mddocs/*.md- In-source comments or docstrings that mention bounty tiers
A repository-wide grep -r '100.*200' docs/ (and similar for em-dash variants) would confirm the change is complete.
RTC RewardThis merged PR earned 5 RTC — sent to |
Closes #7683
RTC wallet: RTCfe13452d122263caf633ab1876bd9631133b68b1
Changes
Testing