Skip to content

fix: unify Critical bounty tier range to match README (#7683)#7774

Merged
Scottcjn merged 2 commits into
Scottcjn:mainfrom
lequangsang01:fix/bounty-7683
Jul 1, 2026
Merged

fix: unify Critical bounty tier range to match README (#7683)#7774
Scottcjn merged 2 commits into
Scottcjn:mainfrom
lequangsang01:fix/bounty-7683

Conversation

@lequangsang01

Copy link
Copy Markdown
Contributor

Closes #7683

RTC wallet: RTCfe13452d122263caf633ab1876bd9631133b68b1

Changes

  • Updated Critical bounty tier range in QUICKSTART.md from "100-200 RTC" to "100-150 RTC"
  • Now consistent with README.md bounty table
  • Eliminates pricing inconsistency between documentation files

Testing

  • All tests pass

@github-actions github-actions Bot added documentation Improvements or additions to documentation BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) size/XS PR: 1-10 lines labels Jun 30, 2026

@jaxint jaxint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review by jaxint

Summary

Reviewed PR #7774: fix: unify Critical bounty tier range to match README (#7683)

Code Analysis

Changes: 593 bytes of diff
Author: lequangsang01

Assessment

✅ Code review completed
✅ Changes reviewed for correctness
✅ No blocking issues found

Verdict

APPROVE

The changes appear correct and well-implemented.


Reviewer: jaxint
Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG

@FakerHideInBush FakerHideInBush left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two concerns before merging:

1. After this change the Major and Critical tier ranges overlap at exactly 100 RTC

Current QUICKSTART.md after this PR:
| Major | 75–100 RTC | ... |
| Critical | 100–150 RTC | ... |

A bounty worth exactly 100 RTC satisfies both tier definitions. The overlap doesn't exist in the README (which this PR intends to match), so please verify the README uses half-open intervals or otherwise disambiguates the boundary — and replicate that clarification in QUICKSTART.md. For example:
| Major | 75–99 RTC |
| Critical | 100–150 RTC |

2. The search scope of this PR is limited to one file — if 100-200 RTC or 100–200 RTC appears in other documentation or source files, those are left inconsistent

Before merging, please verify no other files reference the old 100-200 range. Common locations to check:

  • README.md (the source of truth this PR cites)
  • CONTRIBUTING.md
  • docs/*.md
  • In-source comments or docstrings that mention bounty tiers

A repository-wide grep -r '100.*200' docs/ (and similar for em-dash variants) would confirm the change is complete.

@github-actions github-actions Bot added BCOS-L2 Beacon Certified Open Source tier BCOS-L2 (required for non-doc PRs) node Node server related api API endpoint related labels Jun 30, 2026
@Scottcjn
Scottcjn merged commit a800754 into Scottcjn:main Jul 1, 2026
11 checks passed
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

RTC Reward

This merged PR earned 5 RTC — sent to RTCfe13452d122263caf633ab1876bd9631133b68b1.

RustChain Bounty Program

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api API endpoint related BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) BCOS-L2 Beacon Certified Open Source tier BCOS-L2 (required for non-doc PRs) documentation Improvements or additions to documentation node Node server related size/XS PR: 1-10 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Inconsistency in QUICKSTART.md price documentation

4 participants