Skip to content

Updated the Twitch-Notifications module#67

Merged
SCDerox merged 3 commits intoScootKit:mainfrom
jateute:Twitch-Notifications-Recode
Jun 24, 2022
Merged

Updated the Twitch-Notifications module#67
SCDerox merged 3 commits intoScootKit:mainfrom
jateute:Twitch-Notifications-Recode

Conversation

@jateute
Copy link
Contributor

@jateute jateute commented Jun 20, 2022

No description provided.

@SCDerox
Copy link
Member

SCDerox commented Jun 20, 2022

Hi, thanks for your contribution. Could you provide us with a short list of the most important changes?

@jateute
Copy link
Contributor Author

jateute commented Jun 20, 2022

Changes:

  • Switched to Config-Elements
  • Switched to the new Version of the Libary

Co-authored-by: Simon <simon.csaba@gmx.de>
@SCDerox SCDerox self-assigned this Jun 23, 2022
@SCDerox
Copy link
Member

SCDerox commented Jun 23, 2022

just to make sure, have you tested the functionality with real streamers (real world test)?

(i am to lazy to setup a streaming account just to test this, but the code looks pretty good so far)

@SCDerox
Copy link
Member

SCDerox commented Jun 23, 2022

Also: sorry for the late reply, I've been quite busy the last few days studying (should be in quotes, was more procrastination than actual studying)

@jateute
Copy link
Contributor Author

jateute commented Jun 23, 2022

just to make sure, have you tested the functionality with real streamers (real world test)?

(i am to lazy to setup a streaming account just to test this, but the code looks pretty good so far)

I‘ve tested this on a few Streamers a few times and it always worked.

Copy link
Member

@SCDerox SCDerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks - looking through the code I couldn't find any real issues and I did some testing and everything seems to work as expected ^^
Gona merge it shortly, roll-out should happen today or tomorrow. Also thanks for adding localized configuration properties.

@SCDerox SCDerox merged commit d677770 into ScootKit:main Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants